Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DML EP] Register ReduceMin-20 #20477

Merged
merged 7 commits into from
Jul 26, 2024
+8 −2
Merged

[DML EP] Register ReduceMin-20 #20477

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d5e95c
ReduceMin
aamajumder Apr 26, 2024
7f688f6
Merge branch 'main' into user/aamajumder/reduce
aamajumder Jul 19, 2024
955daec
update OperatorKernels.md
aamajumder Jul 19, 2024
f4affec
filter failing backend test
aamajumder Jul 23, 2024
bba091e
resolve comment
aamajumder Jul 23, 2024
95278d2
comment
aamajumder Jul 23, 2024
5d12738
resolve comment
aamajumder Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/OperatorKernels.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,8 @@ Do not modify directly.*
|||13+|**T** = tensor(float), tensor(float16)|
|||11+|**T** = tensor(float), tensor(float16)|
|||1+|**T** = tensor(float), tensor(float16)|
|ReduceMin|*in* data:**T**<br> *in* axes:**tensor(int64)**<br> *out* reduced:**T**<br><br>or<br><br>*in* data:**T**<br> *out* reduced:**T**|18+|**T** = tensor(float), tensor(float16), tensor(int32), tensor(int64), tensor(uint32), tensor(uint64)|
|ReduceMin|*in* data:**T**<br> *in* axes:**tensor(int64)**<br> *out* reduced:**T**<br><br>or<br><br>*in* data:**T**<br> *out* reduced:**T**|20+|**T** = tensor(bool), tensor(double), tensor(float), tensor(float16), tensor(int16), tensor(int32), tensor(int64), tensor(int8), tensor(uint16), tensor(uint32), tensor(uint64), tensor(uint8)|
|||18+|**T** = tensor(float), tensor(float16), tensor(int32), tensor(int64), tensor(uint32), tensor(uint64)|
|||13+|**T** = tensor(float), tensor(float16), tensor(int16), tensor(int32), tensor(int64), tensor(int8), tensor(uint16), tensor(uint32), tensor(uint64), tensor(uint8)|
|||12+|**T** = tensor(float), tensor(float16), tensor(int16), tensor(int32), tensor(int64), tensor(int8), tensor(uint16), tensor(uint32), tensor(uint64), tensor(uint8)|
|||11+|**T** = tensor(float), tensor(float16)|
Expand Down
1 change: 1 addition & 0 deletions onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/OperatorRegistration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,6 +977,7 @@ constexpr static OperatorRegistrationInformation operatorRegistrationInformation
{REG_INFO( 12, ReduceMin, typeNameListDefault, supportedTypeListFloat16to32Ints8to64, DmlGraphSupport::Supported)},
{REG_INFO( 13, ReduceMin, typeNameListDefault, supportedTypeListFloat16to32Ints8to64, DmlGraphSupport::Supported)},
{REG_INFO( 18, ReduceMin, typeNameListDefault, supportedTypeListFloat16to32Ints32to64, DmlGraphSupport::Supported, requiredConstantCpuInputs(1))},
{REG_INFO( 20, ReduceMin, typeNameListDefault, supportedTypeListAllScalars, DmlGraphSupport::Supported, requiredConstantCpuInputs(1))},
aamajumder marked this conversation as resolved.
Show resolved Hide resolved
{REG_INFO( 7, ArgMax, typeNameListDefault, supportedTypeListArgMinMax, DmlGraphSupport::Supported)},
{REG_INFO( 11, ArgMax, typeNameListDefault, supportedTypeListArgMinMax, DmlGraphSupport::Supported)},
{REG_INFO( 12, ArgMax, typeNameListDefault, supportedTypeListArgMinMax, DmlGraphSupport::Supported)},
Expand Down
1 change: 1 addition & 0 deletions onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorVersions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@
static const int sc_sinceVer_IsNaN = 20;
static const int sc_sinceVer_IsInf = 20;
static const int sc_sinceVer_ReduceMax = 20;
static const int sc_sinceVer_ReduceMin = 20;

Check warning

Code scanning / PREfast

The const variable 'OperatorHelper::OnnxOperatorSet20::sc_sinceVer_ReduceMin' can be computed at compile-time. Consider using constexpr (con.5). Warning

The const variable 'OperatorHelper::OnnxOperatorSet20::sc_sinceVer_ReduceMin' can be computed at compile-time. Consider using constexpr (con.5).
}

namespace MsftOperatorSet1
Expand Down
4 changes: 3 additions & 1 deletion onnxruntime/test/testdata/onnx_backend_test_series_filters.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,9 @@
"^test_constantofshape_int_zeros",
"^test_reduce_log_sum_empty_set_cpu",
"^test_reduce_log_sum_exp_empty_set_cpu",
"^test_reduce_prod_empty_set_cpu"
"^test_reduce_prod_empty_set_cpu",
//DML EP does not execute operators with an empty input tensor
aamajumder marked this conversation as resolved.
Show resolved Hide resolved
"^test_reduce_min_empty_set_cpu"
],
// ORT first supported opset 7, so models with nodes that require versions prior to opset 7 are not supported
"tests_with_pre_opset7_dependencies": [
Expand Down
Loading