[DML EP] Register ReduceMin-20 #20477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -434,6 +434,7 @@ | |||
| static const int sc_sinceVer_IsNaN = 20; | |||
| static const int sc_sinceVer_IsInf = 20; | |||
| static const int sc_sinceVer_ReduceMax = 20; | |||
| static const int sc_sinceVer_ReduceMin = 20; | |||
Check warning
Code scanning / PREfast
The const variable 'OperatorHelper::OnnxOperatorSet20::sc_sinceVer_ReduceMin' can be computed at compile-time. Consider using constexpr (con.5). Warning
fdwr
previously approved these changes
Jul 19, 2024
onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/OperatorRegistration.cpp
Show resolved
Hide resolved
sumitsays
reviewed
Jul 23, 2024
onnxruntime/test/testdata/onnx_backend_test_series_filters.jsonc
Outdated
Show resolved
Hide resolved
sumitsays
reviewed
Jul 23, 2024
onnxruntime/test/testdata/onnx_backend_test_series_filters.jsonc
Outdated
Show resolved
Hide resolved
smk2007
reviewed
Jul 24, 2024
onnxruntime/test/testdata/onnx_backend_test_series_filters.jsonc
Outdated
Show resolved
Hide resolved
fdwr
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR registers the ReduceMin-20 operator to the DML EP.
Motivation and Context