Unconditionally re-enable /W4 on Windows and fix warnings which showed up #19588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've set the compiler warning level for msvc back to /W4 for the CUDA backend to ensure better pre-commit testing and fixed the warnings in the core onnxruntime & CUDA EP which showed up after this change.
Motivation and Context
The warning level on gcc/clang is higher than the one on MSVC when enabling the CUDA backend resulting in CI potential failures when filing a PR developed on Windows. Increase the warning level to have more overlap in warnings between MSVC and gcc/clang.
fix issue #19565