Don't reduce warning level for CUDA build on Windows #19663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
changed the title
|
/azp run Windows GPU TensorRT CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Windows GPU CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Linux GPU CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…where a template parameter is involved.
Fix new resize code. Add some diagnostic info to the ccache install step.
Fix some TRT unit test code causing warnings.
edgchen1
approved these changes
Mar 6, 2024
zz002
pushed a commit
to zz002/onnxruntime
that referenced
this pull request
Mar 7, 2024
### Description <!-- Describe your changes. --> Address warnings so all the ORT projects build with /W4 on Windows. Mainly - unused parameters - variables shadowing other ones ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> microsoft#19588 started on this.
chilo-ms
added a commit
that referenced
this pull request
Apr 2, 2024
Previous [PR ](#19663 msvc compiler warning level from set_msvc_c_cpp_compiler_warning_level(3) to set_msvc_c_cpp_compiler_warning_level(4) when using CUDA EP (it also applies to TRT EP). Some warnings still need to be addressed in TRT EP code.
TedThemistokleous
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
May 7, 2024
Previous [PR ](microsoft#19663 msvc compiler warning level from set_msvc_c_cpp_compiler_warning_level(3) to set_msvc_c_cpp_compiler_warning_level(4) when using CUDA EP (it also applies to TRT EP). Some warnings still need to be addressed in TRT EP code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address warnings so all the ORT projects build with /W4 on Windows.
Mainly
Motivation and Context
#19588 started on this.