Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DML EP] Add Split optimization for Slice operator #18289

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,103 @@ class DmlOperatorSlice : public DmlOperator, public SliceHelper
std::vector<DML_TENSOR_DESC> inputDescs = GetDmlInputDescs();
std::vector<DML_TENSOR_DESC> outputDescs = GetDmlOutputDescs();

DML_SLICE1_OPERATOR_DESC sliceDesc = {};
sliceDesc.InputTensor = inputDescs.data();
sliceDesc.OutputTensor = outputDescs.data();
sliceDesc.DimensionCount = gsl::narrow_cast<uint32_t>(m_offsets.size());
sliceDesc.InputWindowOffsets = m_offsets.data();
sliceDesc.InputWindowSizes = m_sizes.data();
sliceDesc.InputWindowStrides = m_strides.data();

DML_OPERATOR_DESC opDesc = { DML_OPERATOR_SLICE1, &sliceDesc };
SetDmlOperatorDesc(opDesc, kernelInfo);
int splitIndex = GetSplitIndex();

if (splitIndex == -1)
{
DML_SLICE1_OPERATOR_DESC sliceDesc = {};
sliceDesc.InputTensor = inputDescs.data();
sliceDesc.OutputTensor = outputDescs.data();
sliceDesc.DimensionCount = gsl::narrow_cast<uint32_t>(m_offsets.size());
sliceDesc.InputWindowOffsets = m_offsets.data();
sliceDesc.InputWindowSizes = m_sizes.data();
sliceDesc.InputWindowStrides = m_strides.data();

DML_OPERATOR_DESC opDesc = { DML_OPERATOR_SLICE1, &sliceDesc };
SetDmlOperatorDesc(opDesc, kernelInfo);
}
else
{
MLOperatorTensorDataType dataType = kernelInfo.GetInputEdgeDescription(0).tensorDataType;
auto inputSizes = m_inputTensorDescs[0].GetSizes();
std::vector<uint32_t> leftOutputSizes(inputSizes.begin(), inputSizes.end());
leftOutputSizes[splitIndex] = m_offsets[splitIndex];

TensorDesc leftOutputTensorDesc = TensorDesc::ConstructDefaultTensorDesc(dataType, leftOutputSizes);

std::array<DML_TENSOR_DESC, 2> splitOutputs = {
leftOutputTensorDesc.GetDmlDesc(),
outputDescs.back(),
};

DML_SPLIT_OPERATOR_DESC splitDesc = {};
splitDesc.InputTensor = inputDescs.data();
splitDesc.OutputTensors = splitOutputs.data();
splitDesc.OutputCount = gsl::narrow_cast<uint32_t>(splitOutputs.size());
splitDesc.Axis = static_cast<uint32_t>(splitIndex);
const DML_OPERATOR_DESC splitDmlDesc {DML_OPERATOR_SPLIT, &splitDesc};

std::array<const DML_OPERATOR_DESC*, 1> opDescs = {
&splitDmlDesc,
};

std::vector<DML_INPUT_GRAPH_EDGE_DESC> inputEdges;
std::vector<DML_OUTPUT_GRAPH_EDGE_DESC> outputEdges;

DML_INPUT_GRAPH_EDGE_DESC inputEdge = {};
inputEdge.GraphInputIndex = 0;
inputEdge.ToNodeIndex = 0;
inputEdge.ToNodeInputIndex = 0;
inputEdges.push_back(std::move(inputEdge));

DML_OUTPUT_GRAPH_EDGE_DESC outputEdge = {};
outputEdge.GraphOutputIndex = 0;
outputEdge.FromNodeIndex = 0;
outputEdge.FromNodeOutputIndex = 1;
outputEdges.push_back(std::move(outputEdge));

MLOperatorGraphDesc operatorGraphDesc = {};
operatorGraphDesc.inputEdgeCount = gsl::narrow_cast<uint32_t>(inputEdges.size());
operatorGraphDesc.inputEdges = inputEdges.data();
operatorGraphDesc.outputEdgeCount = gsl::narrow_cast<uint32_t>(outputEdges.size());
operatorGraphDesc.outputEdges = outputEdges.data();
operatorGraphDesc.nodeCount = gsl::narrow_cast<uint32_t>(opDescs.size());
operatorGraphDesc.nodesAsOpDesc = opDescs.data();

SetDmlOperatorGraphDesc(std::move(operatorGraphDesc), kernelInfo);
}
}

private:
int GetSplitIndex()
{
if (std::any_of(m_strides.begin(), m_strides.end(), [](int32_t stride){ return stride != 1; }))
{
return -1;
}

int axisIndex = -1;

// For now, we only support cases where the left part of the tensor is getting cut off and we keep the right part
for (uint32_t i = 0; i < m_offsets.size(); ++i)
{
if (m_offsets[i] != 0)
{
if (axisIndex != -1)
{
return -1;
}

if (m_sizes[i] < m_inputTensorDescs[0].GetSizes()[i] - m_offsets[i])
{
return -1;
}

axisIndex = i;
}
}

return axisIndex;
}
};

Expand Down
Loading