Fix missing attribute on C# DOrtGetResizedStringTensorElementBuffer delegate #17901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some long lines as well.
snnn
approved these changes
Oct 12, 2023
|
tks @skottmckay. I ll follow up the PR merge here. |
yuslepukhin
approved these changes
Oct 12, 2023
|
Please add the label for csharp |
|
@skottmckay is there a rough timeplan for v1.16.2 ? |
skottmckay
deleted the
skottmckay/FixMissingUnmanagedFunctionPointerAttribute
branch
Roughly mid-November. |
|
Thanks for your Feedback @skottmckay . Helps planning the next release. |
jchen351
pushed a commit
that referenced
this pull request
Oct 18, 2023
…elegate (#17901) ### Description <!-- Describe your changes. --> Fix missing attribute. Causes build error on release xamarin iOS build. Fix some long lines as well. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> #16463 - once the dummy extensions nuget package is used this problem shows up.
snnn
added a commit
that referenced
this pull request
Nov 2, 2023
Cherry-pick PRs: #18026 #17912 #17901 “2 lines added whitespace errors when cherry-picking" #17293 #17364 #17505 #17885 This PR contains all the cherry-picks for the patch release except: 1. The PRs marked with sdxl_llama 2. #17772 which has a merge conflict. --------- Co-authored-by: Chi Lo <[email protected]> Co-authored-by: Chi Lo <[email protected]> Co-authored-by: Scott McKay <[email protected]> Co-authored-by: Baiju Meswani <[email protected]> Co-authored-by: Kaz Nishimura <[email protected]> Co-authored-by: Scott McKay <[email protected]>
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
…elegate (microsoft#17901) ### Description <!-- Describe your changes. --> Fix missing attribute. Causes build error on release xamarin iOS build. Fix some long lines as well. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> microsoft#16463 - once the dummy extensions nuget package is used this problem shows up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missing attribute. Causes build error on release xamarin iOS build.
Fix some long lines as well.
Motivation and Context
#16463 - once the dummy extensions nuget package is used this problem shows up.