Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cherry-picks for the 1.16.2 release #18218

Merged
merged 25 commits into from
Nov 2, 2023
Merged

Some cherry-picks for the 1.16.2 release #18218

merged 25 commits into from
Nov 2, 2023

Conversation

snnn
Copy link
Member

@snnn snnn commented Nov 1, 2023 •
edited
Loading

Cherry-pick PRs:
#18026
#17912
#17901 “2 lines added whitespace errors when cherry-picking"
#17293
#17364
#17505
#17885

This PR contains all the cherry-picks for the patch release except:

  1. The PRs marked with sdxl_llama
  2. ResizeGrad CUDA/ROCM kernel implementation #17772 which has a merge conflict.

chilo-ms and others added 23 commits November 1, 2023 11:37
@chilo-ms @snnn
update
545036f
@chilo-ms @snnn
update
e0cd0cc
@chilo-ms @snnn
update
4534d8f
@chilo-ms @snnn
update
b2a582a
@chilo-ms @snnn
Fix comment
0ec4b83
@chilo-ms @snnn
fix
e9a8c88
@skottmckay @snnn
Fix missing attribute. Causes build error on release xamarin iOS build.
e718496 
Fix some long lines as well.
@baijumeswani @snnn
Address pull request review comment
5ada1ad
@baijumeswani @snnn
Add rocm execution provider for Sign
d30dcfa
@baijumeswani @snnn
Update operator kernels doc
1e0736c
@baijumeswani @snnn
Add definitions to rocm ep
9c3df04
@baijumeswani @snnn
Update count check in EvalStep C#
9353c91
@baijumeswani @snnn
C, C++ functions for Updating and Getting a checkpoint parameter
b78f80b
@baijumeswani @snnn
Adding UpdateParameter and GetParameter to C#
0ab37c6
@baijumeswani @snnn
Expose model parameters and their gradients in Python
619cb81
@baijumeswani @snnn
Address pull request review comments
9262106
@baijumeswani @snnn
Address C# bindings pull request review comments
17ae5df
@baijumeswani @snnn
Address pull request review comments for C# and C API
a14546e
@baijumeswani @snnn
Address C# comments
6803374
@baijumeswani @snnn
Address C# comments
d8c313d
@baijumeswani @snnn
Address pull request review comments
e1fb060
@baijumeswani @snnn
fix typo
265551e
@kazssym @snnn
Add missing member init
f5fe5da
@snnn snnn changed the title snnn/cr1 Some cherry-picks for the 1.16.2 release Nov 1, 2023
@skottmckay @snnn
Fix illegal opcode error from mlas (microsoft#17885)
321e2ac 
### Description
<!-- Describe your changes. -->
Use cpuinfo value when checking to dot product is available. Reading the
ID_AA64ISAR0_EL1 register is unsafe.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
microsoft#17647 
microsoft#17541 
microsoft#17851
@snnn snnn requested a review from a team as a code owner November 1, 2023 18:50
skottmckay
skottmckay reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@skottmckay skottmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 cherry-picks for mobile are correctly included.

@snnn snnn merged commit 2f57f1e into microsoft:rel-1.16.2 Nov 2, 2023
82 of 94 checks passed
@snnn snnn deleted the snnn/cr1 branch November 2, 2023 17:01
@centwang centwang mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skottmckay skottmckay skottmckay left review comments

@yufenglee yufenglee yufenglee approved these changes

@pranavsharma pranavsharma pranavsharma approved these changes

@baijumeswani baijumeswani Awaiting requested review from baijumeswani

@xadupre xadupre Awaiting requested review from xadupre

@centwang centwang Awaiting requested review from centwang

@chilo-ms chilo-ms Awaiting requested review from chilo-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@snnn @skottmckay @pranavsharma @yufenglee @chilo-ms @baijumeswani @kazssym