Add "glue" between training WASM artifacts and training web #17474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
reviewed
Sep 22, 2023
fs-eire
reviewed
Sep 22, 2023
fs-eire
reviewed
Sep 22, 2023
carzh
force-pushed
the
carzh/training-wasm-binding
branch
from
9885866 to
5adbcf4
Compare
askhade
reviewed
Oct 3, 2023
…ggested fix of adding backend-wasm-inference.ts
fs-eire
reviewed
Oct 11, 2023
fs-eire
reviewed
Oct 11, 2023
fs-eire
approved these changes
Oct 11, 2023
|
/azp run ONNX Runtime React Native CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carzh
added a commit
that referenced
this pull request
Oct 26, 2023
### Description * Adds TrainingSession.create() functionality following the web bindings for training design doc * Added 2 new training APIs to wasm/api.h: * OrtTrainingGetInputOutputName * OrtTrainingGetInputOutputCount * Moved isOrtEnvInitialized boolean to the wasm-core-impl and added a method that references it ### Motivation and Context * Adding web bindings for training #### Related work * #16521 allowed for training artifacts to be built * #17333 added interfaces for training * #17474 allows for training package to be built + adds training backend to web package **[MUST BE MERGED IN BEFORE THIS ONE]** --------- Co-authored-by: Yulong Wang <[email protected]> Co-authored-by: Ashwini Khade <[email protected]>
carzh
added a commit
that referenced
this pull request
Nov 2, 2023
### Description * based on design document & following InferenceSession's run implementation, implemented TrainingSession.runTrainStep ### Motivation and Context * Adding web bindings for training #### Related work * #16521 allowed for training artifacts to be built * #17333 added interfaces for training * #17474 allowed for training package to be built + added training backend to web package * #17891 implementation for createTrainingSession on the TypeScript side **[SHOULD BE MERGED IN BEFORE THIS PR]** --------- Co-authored-by: Yulong Wang <[email protected]> Co-authored-by: Ashwini Khade <[email protected]>
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
…t#17474) ### Description * follows the packaging approach according to the design document * adds `ENABLE_TRAINING` boolean flag to `BUILD_DEFS` * modifies `package.json` to include training submodule * modifies build script to handle, validate, and minimize training WASM artifacts * adds the binding for the new backend with training enabled & the new training artifacts * adds training backend * edits `index.ts` to use training backend depending on `BUILD_DEFS` * edits `wasm-factory.ts` to use the training artifacts if necessary ### Motivation and Context * we are in the process of adding web bindings to enable training. * Adding the "glue" to allow onnxruntime-web to use the training WASM artifacts is required for this work. * Since BUILD_DEFS is defined and used at build time, I thought that it made sense to bundle the changes to building in the same PR. #### Related work * microsoft#16521 allowed for training artifacts to be built * microsoft#17333 must be merged in before this one --------- Co-authored-by: Yulong Wang <[email protected]>
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
### Description * Adds TrainingSession.create() functionality following the web bindings for training design doc * Added 2 new training APIs to wasm/api.h: * OrtTrainingGetInputOutputName * OrtTrainingGetInputOutputCount * Moved isOrtEnvInitialized boolean to the wasm-core-impl and added a method that references it ### Motivation and Context * Adding web bindings for training #### Related work * microsoft#16521 allowed for training artifacts to be built * microsoft#17333 added interfaces for training * microsoft#17474 allows for training package to be built + adds training backend to web package **[MUST BE MERGED IN BEFORE THIS ONE]** --------- Co-authored-by: Yulong Wang <[email protected]> Co-authored-by: Ashwini Khade <[email protected]>
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
### Description * based on design document & following InferenceSession's run implementation, implemented TrainingSession.runTrainStep ### Motivation and Context * Adding web bindings for training #### Related work * microsoft#16521 allowed for training artifacts to be built * microsoft#17333 added interfaces for training * microsoft#17474 allowed for training package to be built + added training backend to web package * microsoft#17891 implementation for createTrainingSession on the TypeScript side **[SHOULD BE MERGED IN BEFORE THIS PR]** --------- Co-authored-by: Yulong Wang <[email protected]> Co-authored-by: Ashwini Khade <[email protected]>
siweic0
pushed a commit
to siweic0/onnxruntime-web
that referenced
this pull request
May 9, 2024
…t#17474) ### Description * follows the packaging approach according to the design document * adds `ENABLE_TRAINING` boolean flag to `BUILD_DEFS` * modifies `package.json` to include training submodule * modifies build script to handle, validate, and minimize training WASM artifacts * adds the binding for the new backend with training enabled & the new training artifacts * adds training backend * edits `index.ts` to use training backend depending on `BUILD_DEFS` * edits `wasm-factory.ts` to use the training artifacts if necessary ### Motivation and Context * we are in the process of adding web bindings to enable training. * Adding the "glue" to allow onnxruntime-web to use the training WASM artifacts is required for this work. * Since BUILD_DEFS is defined and used at build time, I thought that it made sense to bundle the changes to building in the same PR. #### Related work * microsoft#16521 allowed for training artifacts to be built * microsoft#17333 must be merged in before this one --------- Co-authored-by: Yulong Wang <[email protected]>
siweic0
pushed a commit
to siweic0/onnxruntime-web
that referenced
this pull request
May 9, 2024
### Description * Adds TrainingSession.create() functionality following the web bindings for training design doc * Added 2 new training APIs to wasm/api.h: * OrtTrainingGetInputOutputName * OrtTrainingGetInputOutputCount * Moved isOrtEnvInitialized boolean to the wasm-core-impl and added a method that references it ### Motivation and Context * Adding web bindings for training #### Related work * microsoft#16521 allowed for training artifacts to be built * microsoft#17333 added interfaces for training * microsoft#17474 allows for training package to be built + adds training backend to web package **[MUST BE MERGED IN BEFORE THIS ONE]** --------- Co-authored-by: Yulong Wang <[email protected]> Co-authored-by: Ashwini Khade <[email protected]>
siweic0
pushed a commit
to siweic0/onnxruntime-web
that referenced
this pull request
May 9, 2024
### Description * based on design document & following InferenceSession's run implementation, implemented TrainingSession.runTrainStep ### Motivation and Context * Adding web bindings for training #### Related work * microsoft#16521 allowed for training artifacts to be built * microsoft#17333 added interfaces for training * microsoft#17474 allowed for training package to be built + added training backend to web package * microsoft#17891 implementation for createTrainingSession on the TypeScript side **[SHOULD BE MERGED IN BEFORE THIS PR]** --------- Co-authored-by: Yulong Wang <[email protected]> Co-authored-by: Ashwini Khade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ENABLE_TRAININGboolean flag toBUILD_DEFSpackage.jsonto include training submoduleindex.tsto use training backend depending onBUILD_DEFSwasm-factory.tsto use the training artifacts if necessaryMotivation and Context
Related work