Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js/web/training] Add CreateTrainingSession #17891

Merged
merged 24 commits into from
Oct 26, 2023

Conversation

carzh
Copy link
Contributor

@carzh carzh commented Oct 11, 2023

Description

  • Adds TrainingSession.create() functionality following the web bindings for training design doc
  • Added 2 new training APIs to wasm/api.h:
    • OrtTrainingGetInputOutputName
    • OrtTrainingGetInputOutputCount
  • Moved isOrtEnvInitialized boolean to the wasm-core-impl and added a method that references it

Motivation and Context

  • Adding web bindings for training

Related work

js/web/lib/wasm/wasm-training-core-impl.ts Fixed Show fixed Hide fixed
js/web/lib/wasm/proxy-wrapper.ts Fixed Show fixed Hide fixed
js/web/lib/wasm/session-handler.ts Fixed Show fixed Hide fixed
@carzh carzh force-pushed the carzh/create-training-session branch from 06e8f74 to 05a708f Compare October 17, 2023 00:03
@carzh carzh requested review from guschmue and askhade October 17, 2023 18:41
onnxruntime/wasm/api.h Outdated Show resolved Hide resolved
@carzh carzh requested a review from askhade October 24, 2023 18:23
onnxruntime/wasm/api.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@askhade askhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

@carzh carzh merged commit 64de71c into microsoft:main Oct 26, 2023
82 of 85 checks passed
carzh added a commit that referenced this pull request Nov 2, 2023
### Description
* based on design document & following InferenceSession's run
implementation, implemented TrainingSession.runTrainStep

### Motivation and Context
* Adding web bindings for training

#### Related work
* #16521 allowed for training artifacts to be built
* #17333 added interfaces for training
* #17474 allowed for training package to be built + added training
backend to web package
* #17891 implementation for createTrainingSession on the TypeScript side
**[SHOULD BE MERGED IN BEFORE THIS PR]**

---------

Co-authored-by: Yulong Wang <[email protected]>
Co-authored-by: Ashwini Khade <[email protected]>
@carzh carzh deleted the carzh/create-training-session branch December 20, 2023 22:32
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
### Description
* Adds TrainingSession.create() functionality following the web bindings
for training design doc
* Added 2 new training APIs to wasm/api.h:
   * OrtTrainingGetInputOutputName
   * OrtTrainingGetInputOutputCount
* Moved isOrtEnvInitialized boolean to the wasm-core-impl and added a
method that references it

### Motivation and Context
* Adding web bindings for training

#### Related work
* microsoft#16521 allowed for training artifacts to be built
* microsoft#17333 added interfaces for training
* microsoft#17474 allows for training package to be built + adds training backend
to web package **[MUST BE MERGED IN BEFORE THIS ONE]**

---------

Co-authored-by: Yulong Wang <[email protected]>
Co-authored-by: Ashwini Khade <[email protected]>
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
### Description
* based on design document & following InferenceSession's run
implementation, implemented TrainingSession.runTrainStep

### Motivation and Context
* Adding web bindings for training

#### Related work
* microsoft#16521 allowed for training artifacts to be built
* microsoft#17333 added interfaces for training
* microsoft#17474 allowed for training package to be built + added training
backend to web package
* microsoft#17891 implementation for createTrainingSession on the TypeScript side
**[SHOULD BE MERGED IN BEFORE THIS PR]**

---------

Co-authored-by: Yulong Wang <[email protected]>
Co-authored-by: Ashwini Khade <[email protected]>
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
### Description
* Adds TrainingSession.create() functionality following the web bindings
for training design doc
* Added 2 new training APIs to wasm/api.h:
   * OrtTrainingGetInputOutputName
   * OrtTrainingGetInputOutputCount
* Moved isOrtEnvInitialized boolean to the wasm-core-impl and added a
method that references it

### Motivation and Context
* Adding web bindings for training

#### Related work
* microsoft#16521 allowed for training artifacts to be built
* microsoft#17333 added interfaces for training
* microsoft#17474 allows for training package to be built + adds training backend
to web package **[MUST BE MERGED IN BEFORE THIS ONE]**

---------

Co-authored-by: Yulong Wang <[email protected]>
Co-authored-by: Ashwini Khade <[email protected]>
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
### Description
* based on design document & following InferenceSession's run
implementation, implemented TrainingSession.runTrainStep

### Motivation and Context
* Adding web bindings for training

#### Related work
* microsoft#16521 allowed for training artifacts to be built
* microsoft#17333 added interfaces for training
* microsoft#17474 allowed for training package to be built + added training
backend to web package
* microsoft#17891 implementation for createTrainingSession on the TypeScript side
**[SHOULD BE MERGED IN BEFORE THIS PR]**

---------

Co-authored-by: Yulong Wang <[email protected]>
Co-authored-by: Ashwini Khade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants