Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pool to MacOS-13 #17361

Merged
merged 44 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
acf9f65
Update pool to MacOS-13
jchen351 Aug 30, 2023
1af95ce
Merge branch 'main' into Cjian/macos13
jchen351 Nov 17, 2023
32d19a8
Merge branch 'refs/heads/main' into Cjian/macos13
jchen351 May 15, 2024
55a21b0
Merge remote-tracking branch 'origin/main' into Cjian/macos13
jchen351 Jun 21, 2024
912c9a5
update jave sdk from 11 to 17
jchen351 Jun 24, 2024
f820cf5
Use Xcode version 14.3 instead of
jchen351 Jun 24, 2024
3d3389e
14.3.1
jchen351 Jun 24, 2024
93ec7e2
macOS-13
jchen351 Jun 24, 2024
ee9dfc4
macOS-13
jchen351 Jun 24, 2024
53a03b1
Merge branch 'refs/heads/main' into Cjian/macos13
jchen351 Jun 26, 2024
f0ca208
update ios target to 15
jchen351 Jun 28, 2024
ffb6f5c
Merge remote-tracking branch 'origin/main' into Cjian/macos13
snnn Jun 29, 2024
c85fdd7
Merge branch 'refs/heads/main' into Cjian/macos13
jchen351 Jul 17, 2024
da23b72
Installing gcovr from apt-get
jchen351 Jul 17, 2024
ba098ad
Reverting podfile and project files
jchen351 Aug 22, 2024
2ac15bf
Merge branch 'refs/heads/main' into Cjian/macos13
jchen351 Aug 23, 2024
095761b
Merge remote-tracking branch 'refs/remotes/origin/main' into Cjian/ma…
jchen351 Aug 26, 2024
7fa3ac3
Merging back with the master
jchen351 Aug 26, 2024
8b2c66e
Remove xcodeVersion when they are using the default version
jchen351 Aug 26, 2024
6029138
Merge branch 'refs/heads/main' into Cjian/macos13
jchen351 Aug 26, 2024
45aa698
use-xcode-version.yml
jchen351 Aug 27, 2024
ae823f2
Trying Xcode 14.2 with the MacOS-13
jchen351 Aug 27, 2024
e264fae
Try to update to use ios simulator ios version 15
jchen351 Aug 27, 2024
416d697
Update the xcode project.pbxproj
jchen351 Aug 27, 2024
11916d4
Update targert iOS and MacOS in project setting
jchen351 Aug 30, 2024
6782c3c
Update targert iOS and MacOS in project setting
jchen351 Aug 30, 2024
fe1dd8e
Update targert iOS and MacOS in project setting
jchen351 Aug 30, 2024
21215b0
Update targert iOS and MacOS in project setting
jchen351 Aug 30, 2024
324755d
Try setting RCTBlobManager manually
jchen351 Aug 30, 2024
3b12d4a
Reverting the changes
jchen351 Aug 30, 2024
4e7291f
Set pod deployment target to 13.0
jchen351 Aug 30, 2024
572697c
Retry xcode 14.2 again
jchen351 Sep 3, 2024
02faf93
Retry xcode 14.3 with need post installer config
jchen351 Sep 3, 2024
df9ae3e
Apply fix for https://github.com/facebook/react-native/issues/32483
jchen351 Sep 4, 2024
dedeaad
Apply fix for https://github.com/facebook/react-native/issues/32483
jchen351 Sep 4, 2024
1296dd3
Update time.h
jchen351 Sep 4, 2024
0f29f75
Update project.pbxproj
jchen351 Sep 4, 2024
4ff2120
define iOS to 13.0 because default iOS version 17.2
jchen351 Sep 11, 2024
c70e7d7
define iOS to 13.0 because default iOS version 17.2
jchen351 Sep 11, 2024
c7d3de8
Change the simulator device type to iphone 11, because ios 13 cannot …
jchen351 Sep 11, 2024
183ccaa
Change the simulator device type to iphone 11, because the default iO…
jchen351 Sep 12, 2024
d11a6ef
Adding script to check the list of supported devices
jchen351 Sep 12, 2024
69c5eb6
iPhone 13 is no longer supported with current MacOS image so I am usi…
jchen351 Sep 12, 2024
6e5f286
Using iPhone 14 with iOS 16.4 for xcode Instrumented Tests
jchen351 Sep 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ stages:
versionSpec: $(pythonVersion)

- task: JavaToolInstaller@0
displayName: Use jdk 11
displayName: Use jdk 17
inputs:
versionSpec: '11'
versionSpec: '17'
snnn marked this conversation as resolved.
Show resolved Hide resolved
jdkArchitectureOption: 'x64'
jdkSourceOption: 'PreInstalled'

Expand Down Expand Up @@ -130,9 +130,9 @@ stages:
versionSpec: $(pythonVersion)

- task: JavaToolInstaller@0
displayName: Use jdk 11
displayName: Use jdk 17
inputs:
versionSpec: '11'
versionSpec: '17'
jdkArchitectureOption: 'x64'
jdkSourceOption: 'PreInstalled'

Expand Down Expand Up @@ -194,9 +194,9 @@ stages:
versionSpec: $(pythonVersion)

- task: JavaToolInstaller@0
displayName: Use jdk 11
displayName: Use jdk 17
inputs:
versionSpec: '11'
versionSpec: '17'
jdkArchitectureOption: 'x64'
jdkSourceOption: 'PreInstalled'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
workspace:
clean: all
pool:
vmImage: 'macOS-latest'
vmImage: 'macOS-13'
variables:
MACOSX_DEPLOYMENT_TARGET: '11.0'
TODAY: $[format('{0:dd}{0:MM}{0:yyyy}', pipeline.startTime)]
Expand All @@ -43,8 +43,6 @@ jobs:
displayName: Install coreutils and ninja

- template: templates/use-xcode-version.yml
parameters:
xcodeVersion: 14.2

- template: templates/mac-build-step-with-cache.yml
parameters:
Expand Down
5 changes: 2 additions & 3 deletions tools/ci_build/github/azure-pipelines/mac-ios-ci-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,15 @@ pr:
jobs:
- job: iOS_CI_on_Mac
pool:
vmImage: 'macOS-latest'
vmImage: 'macOS-13'
variables:
PROTO_CACHE_DIR: $(Pipeline.Workspace)/proto_ccache
ORT_CACHE_DIR: $(Pipeline.Workspace)/ort_ccache
TODAY: $[format('{0:dd}{0:MM}{0:yyyy}', pipeline.startTime)]
timeoutInMinutes: 150
steps:
- template: templates/use-xcode-version.yml
parameters:
xcodeVersion: 14.2

- template: templates/mac-build-step-with-cache.yml
parameters:
WithCache: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ stages:
displayName: "Set common variables"

pool:
vmImage: "macOS-latest"
vmImage: "macOS-13"

timeoutInMinutes: 5

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ stages:
clean: all
timeoutInMinutes: 120
pool:
vmImage: 'macOS-latest'
vmImage: 'macOS-13'

variables:
- name: OnnxRuntimeBuildDirectory
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ stages:
workspace:
clean: all
pool:
vmImage: 'macOS-latest'
vmImage: 'macOS-13'

variables:
- name: OnnxRuntimeBuildDirectory
Expand Down
8 changes: 2 additions & 6 deletions tools/ci_build/github/azure-pipelines/post-merge-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ stages:
- job: IosDynamicFramework
timeoutInMinutes: 120
pool:
vmImage: "macOS-latest"
vmImage: "macOS-13"

steps:
- task: UsePythonVersion@0
Expand All @@ -435,8 +435,6 @@ stages:
architecture: "x64"

- template: templates/use-xcode-version.yml
parameters:
xcodeVersion: 14.2

- script: |
pip install -r tools/ci_build/github/apple/ios_packaging.requirements.txt
Expand All @@ -463,7 +461,7 @@ stages:
- job: IosMinimalTrainingBuild
timeoutInMinutes: 120
pool:
vmImage: "macOS-latest"
vmImage: "macOS-13"

steps:
- task: UsePythonVersion@0
Expand All @@ -473,8 +471,6 @@ stages:
architecture: "x64"

- template: templates/use-xcode-version.yml
parameters:
xcodeVersion: 14.2

- script: |
pip install -r tools/ci_build/github/apple/ios_packaging.requirements.txt
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ stages:
parameters:
job_name: Test_MAC_Wheels
machine_pool:
vmImage: 'macOS-latest'
vmImage: 'macOS-13'
itemPattern: '*/*mac*x86_64.whl'
- template: templates/py-package-smoking-test.yml
parameters:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ jobs:
workspace:
clean: all
pool:
# We need macOS-12 to run the Android emulator for now.
# https://github.com/actions/runner-images/issues/7671
vmImage: 'macOS-12'
vmImage: 'macOS-13'
variables:
- name: runCodesignValidationInjection
value: false
Expand All @@ -39,9 +37,9 @@ jobs:
targetPath: '$(Build.BinariesDirectory)/final-android-aar'

- task: JavaToolInstaller@0
displayName: Use jdk 11
displayName: Use jdk 17
inputs:
versionSpec: '11'
versionSpec: '17'
jdkArchitectureOption: 'x64'
jdkSourceOption: 'PreInstalled'

Expand Down
8 changes: 3 additions & 5 deletions tools/ci_build/github/azure-pipelines/templates/c-api-cpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,12 @@ stages:
workspace:
clean: all
pool:
vmImage: 'macOS-latest'
vmImage: 'macOS-13'
timeoutInMinutes: 300
steps:
- template: set-version-number-variables-step.yml

- template: use-xcode-version.yml
parameters:
xcodeVersion: 14.2

- template: download-deps.yml

Expand Down Expand Up @@ -779,7 +777,7 @@ stages:

- template: ../nuget/templates/test_macos.yml
parameters:
AgentPool : macOS-latest
AgentPool : macOS-13
ArtifactSuffix: 'CPU'

- template: ../nodejs/templates/test_win.yml
Expand Down Expand Up @@ -815,4 +813,4 @@ stages:
OS: MacOS
BuildId: ${{ parameters.BuildId }}
SpecificArtifact: ${{ parameters.SpecificArtifact }}
PoolName: 'macOS-latest'
PoolName: 'macOS-13'
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ stages:
- job: MacOS_C_API_Package_Publish
pool:
${{ if eq(parameters.DoESRP, true)}}:
vmImage: 'macOS-12'
vmImage: 'macOS-13'
${{ else }}:
vmImage: 'macOS-latest'
vmImage: 'macOS-13'
steps:
- checkout: none
- template: flex-downloadPipelineArtifact.yml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
PROTO_CACHE_DIR: $(Pipeline.Workspace)/ccache_proto
ORT_CACHE_DIR: $(Pipeline.Workspace)/ccache_ort
pool:
vmImage: 'macOS-latest'
vmImage: 'macOS-13'
timeoutInMinutes: 300
steps:
- checkout: self
Expand All @@ -61,8 +61,6 @@ jobs:
- template: set-version-number-variables-step.yml

- template: use-xcode-version.yml
parameters:
xcodeVersion: 14.2

- template: download-deps.yml

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ stages:
workspace:
clean: all
pool:
vmImage: 'macOS-latest'
vmImage: 'macOS-13'
variables:
MACOSX_DEPLOYMENT_TARGET: '11.0'
strategy:
Expand All @@ -419,8 +419,6 @@ stages:
versionSpec: $(PythonVersion)

- template: use-xcode-version.yml
parameters:
xcodeVersion: 14.2

- template: download-deps.yml

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ stages:

- job: Build_Ios_Pod_For_React_Native
pool:
vmImage: 'macOS-12'
vmImage: 'macOS-13'

timeoutInMinutes: 90

Expand All @@ -52,7 +52,6 @@ stages:

steps:
- template: use-xcode-version.yml

- task: UsePythonVersion@0
displayName: Use python 3.9
inputs:
Expand Down Expand Up @@ -99,17 +98,15 @@ stages:
jobs:
- job: ReactNative_CI
pool:
# We need macOS-12 to run the Android emulator for now.
# https://github.com/actions/runner-images/issues/7671
vmImage: 'macOS-12'
vmImage: 'macOS-13'
variables:
runCodesignValidationInjection: false
timeoutInMinutes: 90
steps:
- task: mspremier.PostBuildCleanup.PostBuildCleanup-task.PostBuildCleanup@3
displayName: Clean Agent Directories
condition: always()

- template: use-xcode-version.yml
jchen351 marked this conversation as resolved.
Show resolved Hide resolved
- task: UsePythonVersion@0
displayName: Use python 3.9
inputs:
Expand All @@ -118,9 +115,9 @@ stages:
architecture: "x64"

- task: JavaToolInstaller@0
displayName: Use jdk 11
displayName: Use jdk 17
inputs:
versionSpec: '11'
versionSpec: '17'
jdkArchitectureOption: 'x64'
jdkSourceOption: 'PreInstalled'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ stages:
displayName: "Build iOS package for variant: ${{ parameters.packageVariant}}"

pool:
vmImage: "macOS-latest"
vmImage: "macOS-13"

variables:
xcodeVersion: "14.2"
xcodeVersion: "14.3.1"
ortPodVersion: $[stageDependencies.IosPackaging_SetCommonVariables.j.outputs['SetCommonVariables.ORT_POD_VERSION']]

${{ if eq(parameters.packageVariant, 'Full') }}:
Expand Down Expand Up @@ -62,8 +62,6 @@ stages:
architecture: "x64"

- template: ../use-xcode-version.yml
parameters:
xcodeVersion: ${{ variables.xcodeVersion }}

- template: ../install-appcenter.yml

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
parameters:
- name: xcodeVersion
type: string
default: "14.2"
default: "14.3.1"

steps:
- bash: |
Expand Down
Loading