-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pool to MacOS-13 #17361
Merged
Merged
Update pool to MacOS-13 #17361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI, I ran into a build failure earlier when I tried this. |
# Conflicts: # tools/python/util/android/android.py
Please make sure the Android CI pipeline and ONNX Runtime React Native CI Pipeline could pass. |
snnn
reviewed
Jun 24, 2024
tools/ci_build/github/azure-pipelines/templates/stages/mac-ios-packaging-build-stage.yml
Outdated
Show resolved
Hide resolved
The "MacOS_C_API_Packaging_CPU_x86_64" build job still uses macOS-12. |
skottmckay
added a commit
that referenced
this pull request
Jun 25, 2024
jchen351
pushed a commit
that referenced
this pull request
Jun 26, 2024
### Description <!-- Describe your changes. --> Convert scalars to 1D to satisfy ML Program requirements. https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1418617&view=logs&j=f7cc61a9-cc70-56e7-b06c-4668ca17e426&t=16d281b5-1bfd-5309-f274-36d0dffd9cb1&l=27167 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Fixes test failure in #17361
# Conflicts: # tools/ci_build/github/azure-pipelines/android-x86_64-crosscompile-ci-pipeline.yml
…support iphone 13
Used to be working prior to 9/11/2024. |
jchen351
commented
Sep 11, 2024
snnn
reviewed
Sep 12, 2024
tools/ci_build/github/azure-pipelines/android-x86_64-crosscompile-ci-pipeline.yml
Show resolved
Hide resolved
…S version is 17.2 which our current xcode version 14.3.1 cannot support
snnn
approved these changes
Sep 17, 2024
AB#48900 |
mszhanyi
added a commit
that referenced
this pull request
Sep 19, 2024
### Description Fix regression caused by #17361 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See microsoft/onnxruntime-extensions#476
and actions/runner-images#7671
Motivation and Context
Current issue
Run React Native Detox Android e2e Test
Failed.Possible flaky test, Improve stability of Android ReactNative E2E test #21969
Build React Native Detox iOS e2e Tests
Applied following code to the eof in both ios/Podfile and fixed the issue
Applying changes to ios/Pofile
dependent
AB#48900