-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CUDAToolkit_ROOT #33
Merged
Merged
Changes from 15 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
53cfd4a
Fix CUDAToolkit_ROOT
jchen351 0316086
Fix CUDAToolkit_ROOT
jchen351 5d76248
Fix CUDAToolkit_ROOT
jchen351 88c815c
Fix CUDAToolkit_ROOT
jchen351 5505cf8
Fix CUDAToolkit_ROOT
jchen351 d9d00d3
Fix CUDAToolkit_ROOT
jchen351 31e4e98
Fix CUDAToolkit_ROOT
jchen351 4ab0a6a
Fix CUDAToolkit_ROOT
jchen351 9f36534
Fix CUDAToolkit_ROOT
jchen351 d23eeb2
Fix CUDAToolkit_ROOT
jchen351 8e93216
Fix CUDAToolkit_ROOT
jchen351 5c59598
Fix CUDAToolkit_ROOT
jchen351 9b9a0ef
set CUDAToolkit_ROOT
jchen351 b9812e3
set CUDAToolkit_ROOT
jchen351 607b7d8
set CUDAToolkit_ROOT
jchen351 36983f0
set CUDAToolkit_ROOT
jchen351 cff8ce6
Set CMAKE_CUDA_COMPILER
jchen351 14d6775
Set CMAKE_CUDA_COMPILER
jchen351 7fed7a3
Merge branch 'main' into Cjian/fix-linux-gpu
jchen351 5be930b
fix yml error
jchen351 3e97f2f
fix yml error
jchen351 e2f74a8
fix yml error
jchen351 352b83b
fix yml error
jchen351 52d2265
fix yml error
jchen351 960bd4a
fix yml error
jchen351 b757f1b
fix yml error
jchen351 ba2b75f
Disable linux build for now.
jchen351 11e2c2a
Try to remove -DCMAKE_BUILD_TYPE=Release -DUSE_CUDA=TRUE
jchen351 a30bb35
Adding check language CUDA back
jchen351 c557c2e
changing CMAKE_CUDA_COMPILER
jchen351 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use "find_package" for CUDA. The usage is deprecated.
See: https://cliutils.gitlab.io/modern-cmake/chapters/packages/CUDA.html.
If you want to use FindCUDAToolkit , at least you should keep the original line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use FindCUDAToolkit to find a variety of useful targets and variables even without enabling the CUDA language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is from the link you sent me.