Fix CUDAToolkit_ROOT #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
reviewed
Jan 24, 2024
CMakeLists.txt
Outdated
| @@ -11,9 +11,11 @@ set(USE_ORT_EXT 0) # "Build with Onnxruntime Extensions tokenizer support" | |||
|
|
|||
| # Checking if CUDA is supported | |||
| include(CheckLanguage) | |||
| check_language(CUDA) | |||
| if (CMAKE_CUDA_COMPILER) | |||
| find_package(CUDAToolkit) | |||
There was a problem hiding this comment.
We shouldn't use "find_package" for CUDA. The usage is deprecated.
See: https://cliutils.gitlab.io/modern-cmake/chapters/packages/CUDA.html.
If you want to use FindCUDAToolkit , at least you should keep the original line.
There was a problem hiding this comment.
You can use FindCUDAToolkit to find a variety of useful targets and variables even without enabling the CUDA language.
There was a problem hiding this comment.
That is from the link you sent me.
snnn
previously requested changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily involves changes to the CUDA toolkit configuration in the
win-gpu-x64-build.ymlGitHub workflow and theCMakeLists.txtfile. The changes ensure that the CUDA toolkit is correctly downloaded and its location is properly defined for subsequent use in the build process.Key changes include:
.github/workflows/win-gpu-x64-build.yml: AddedCUDAToolkit_ROOTenvironment variable to store the location of the CUDA toolkit..github/workflows/win-gpu-x64-build.yml: Modified theDownload cudajob to download the CUDA toolkit to the workspace directory and added a newVerify Cuda SDKjob to print the CUDA toolkit location for verification..github/workflows/win-gpu-x64-build.yml: Modified thecmakecommand in thebuildjob to include theCUDAToolkit_ROOTenvironment variable, ensuring that the build process correctly locates the CUDA toolkit.CMakeLists.txt: Replaced thecheck_language(CUDA)command withFindCUDAToolkitto find the CUDA toolkit during the configuration process, and added a status message when CUDA is not found.