Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MsGraphicsPkg] Fix the bounds of the Trashcan within the ListBox #553

Closed
wants to merge 1 commit into from
Closed

[MsGraphicsPkg] Fix the bounds of the Trashcan within the ListBox #553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MsGraphicsPkg/Library/SimpleUIToolKit/ListBox.c
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenbhou, this is a duplicate of #552.

I initially held off reviewing that PR because it is failing CI, but it appears to just be a Uncrustify issue that I'm happy to fix and push. It has an additional change not here.

Since that was submitted beforehand, are you okay closing this PR in favor that one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, will close this one.

Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,7 @@ Ctor (

SWM_RECT_INIT2 (
this->m_pCells[Index].CellTrashcanBounds,
CellBounds->Left,
CellBounds->Right - TrashcanHitAreaWidth,
CellBounds->Top,
CheckBoxHitAreaWidth,
SWM_RECT_HEIGHT (*CellBounds)
Expand Down
Loading