Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Reference to PcdAdvancedHdwLoggerDisable in README #539

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions AdvLoggerPkg/AdvLoggerPkg.dec
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,6 @@
#
gAdvLoggerPkgTokenSpaceGuid.PcdAdvancedLoggerFixedInRAM|FALSE|BOOLEAN|0x00010189

## PcdAdvancedLoggerPeiInRAM - Tells the PEI Advanced Logger that this PEI can allocate memory
# and there is no need for a temporary memory buffer
#
gAdvLoggerPkgTokenSpaceGuid.PcdAdvancedLoggerPeiInRAM|FALSE|BOOLEAN|0x00010185

## PcdAdvancedLoggerLocator - Tells the Advanced Logger to publish a variable with the logger info block address
#
gAdvLoggerPkgTokenSpaceGuid.PcdAdvancedLoggerLocator|FALSE|BOOLEAN|0x00010186
Expand Down
4 changes: 1 addition & 3 deletions AdvLoggerPkg/Docs/ReadMe.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ The following configurations are supported:
| --- | --- |
| DXE Only | Uses DxeCore, DxeRuntime, and Dxe AdvancedLoggerLib libraries for logging from start of DXE CORE through Exit Boot Services. Accepts the PEI Advanced Logger Hob if one is generated. Produces the AdvancedLogger protocol. |
| DXE+SMM | Requires DXE modules above, and adds the Smm AdvancedLoggerLib library. Collects SMM generated messages in the in memory log. |
| PEI | Uses PeiCore and Pei AdvancedLoggerLib libraries. Creates the Advanced Logger Hob if PcdAdvancedLoggerPeiInRAM is set. |
| PEI | Uses PeiCore and Pei AdvancedLoggerLib libraries. |
| SEC | Uses the Sec Advanced Logger Library. SEC requires a fixed load address, so it piggy backs on the Temporary RAM PCD information. Produces a Fixed Address temporary RAM log. When memory is added, the Sec Advanced Logger library converts the Temporary RAM logging information to the PEI Advanced Logger Hob. |
| PEI64 | Uses Pei64 Advanced Logger Library. Requires the SEC fixed address temporary log information in order to log Pei64 bit DEBUG messages. |
| MM | Standalone MM - Loads during PEI phase. |
Expand All @@ -25,10 +25,8 @@ PCD's used by Advanced Logger
| PCD | Function of the PCD|
| --- | --- |
|PcdAdvancedLoggerForceEnable | The default operation is to check if a Logs directory is present in the root of the filesystem. If the UefiLogs directory is present, logging is enabled. When PcdAdvancedLoggerForceEnable is TRUE, and the device is not a USB device, a UefiLogs directory will be created and logging is enabled. When logging is enabled, the proper log files will be created if not already preset.|
|PcdAdvancedLoggerPeiInRAM | For systems that have memory at PeiCore entry. The full in memory log buffer if PcdAdvancedLoggerPages is allocated in the Pei Core constructor and PcdAdvancedLoggerPreMemPages is ignored.|
|PcdAdvancedLoggerFixedInRAM | For systems that have a fixed memory buffer prior to UEFI. The full in memory log buffer is assumed.|
|PcdAdvancedHdwLoggerDebugPrintErrorLevel | The standard debug flags filter which log messages are produced. This PCD allow a subset of log messages to be forwarded to the Hdw Port Lib.|
|PcdAdvancedHdwLoggerDisable | Specifies when to disable writing to the Hdw Port.|
|PcdAdvancedLoggerPreMemPages | Amount of temporary RAM used for the debug log.|
|PcdAdvancedLoggerPages | Amount of system RAM used for the debug log|
|PcdAdvancedLoggerLocator | When enabled, the AdvLogger creates a variable "AdvLoggerLocator" with the address of the LoggerInfo buffer|
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ ValidateInfoBlock (

The following PCD settings are assumed:

PcdAdvancedLoggerPeiInRAM -- TRUE
PcdAdvancedLoggerBase -- NOT NULL and pointer to memory to be used
PcdAdvancedLoggerPages -- > 64KB of pages
PcdAdvancedLoggerCarBase -- NOT USED, leave at default
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

The following PCD settings are assumed:

PcdAdvancedLoggerPeiInRAM -- TRUE
PcdAdvancedLoggerBase -- NOT NULL and pointer to memory to be used
PcdAdvancedLoggerPages -- > 64KB of pages
PcdAdvancedLoggerCarBase -- NOT USED, leave at default
Expand Down
24 changes: 3 additions & 21 deletions AdvLoggerPkg/Library/AdvancedLoggerLib/PeiCore/AdvancedLoggerLib.c
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ AdvancedLoggerGetLoggerInfo (
UINTN Pages;
CONST EFI_PEI_SERVICES **PeiServices;
EFI_STATUS Status;
EFI_MEMORY_TYPE Type;
ADVANCED_LOGGER_MESSAGE_ENTRY_V2 *LogEntry;

// Try to do the minimum work at the start of this function as this
Expand Down Expand Up @@ -553,19 +552,12 @@ AdvancedLoggerGetLoggerInfo (
// Memory Discovered Ppi. At that time, the full in memory log buffer is allocated.
//

if (FeaturePcdGet (PcdAdvancedLoggerPeiInRAM)) {
Pages = FixedPcdGet32 (PcdAdvancedLoggerPages);
Type = EfiRuntimeServicesData;
} else {
Pages = FixedPcdGet32 (PcdAdvancedLoggerPreMemPages);
// This is to avoid the interim buffer being allocated to consume 64KB on ARM64 platforms.
Type = EfiBootServicesData;
}
Pages = FixedPcdGet32 (PcdAdvancedLoggerPreMemPages);

BufferSize = EFI_PAGES_TO_SIZE (Pages);

Status = PeiServicesAllocatePages (
Type,
EfiBootServicesData,
Pages,
&NewLoggerInfo
);
Expand Down Expand Up @@ -623,17 +615,7 @@ AdvancedLoggerGetLoggerInfo (
Status = PeiServicesInstallPpi (mAdvancedLoggerPpiList);
ASSERT_EFI_ERROR (Status);

if (FeaturePcdGet (PcdAdvancedLoggerPeiInRAM)) {
LoggerInfo->InPermanentRAM = TRUE;
Status = MmUnblockMemoryRequest (NewLoggerInfo, Pages);
if (EFI_ERROR (Status)) {
if (Status != EFI_UNSUPPORTED) {
DEBUG ((DEBUG_ERROR, "%a: Unable to notify StandaloneMM. Code=%r\n", __FUNCTION__, Status));
}
} else {
DEBUG ((DEBUG_INFO, "%a: StandaloneMM Hob data published\n", __FUNCTION__));
}
} else if (FeaturePcdGet (PcdAdvancedLoggerFixedInRAM)) {
if (FeaturePcdGet (PcdAdvancedLoggerFixedInRAM)) {
DEBUG ((DEBUG_INFO, "%a: Standalone MM Hob of fixed data published\n", __FUNCTION__));
} else {
PeiServicesNotifyPpi (mMemoryDiscoveredNotifyList);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
gEfiPeiMemoryDiscoveredPpiGuid ## CONSUMES

[FeaturePcd]
gAdvLoggerPkgTokenSpaceGuid.PcdAdvancedLoggerPeiInRAM ## CONSUMES
gAdvLoggerPkgTokenSpaceGuid.PcdAdvancedLoggerFixedInRAM ## CONSUMES
gAdvLoggerPkgTokenSpaceGuid.PcdAdvancedLoggerAutoWrapEnable

Expand Down
Loading