Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Reference to PcdAdvancedHdwLoggerDisable in README #539

Conversation

Raymond-MS
Copy link
Contributor

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

Removed the reference to PcdAdvancedHdwLoggerDisable in the ReadMe MarkDown document

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Ran CI on all packages for X64 architecture, all tests pass

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Aug 5, 2024
@Raymond-MS Raymond-MS linked an issue Aug 5, 2024 that may be closed by this pull request
1 task
@Raymond-MS Raymond-MS requested a review from os-d August 5, 2024 22:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.02%. Comparing base (f0c8e10) to head (3833901).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311     #539   +/-   ##
===============================================
  Coverage           11.01%   11.02%           
===============================================
  Files                 144      144           
  Lines               22079    22065   -14     
  Branches             2356     2356           
===============================================
  Hits                 2432     2432           
+ Misses              19615    19601   -14     
  Partials               32       32           
Flag Coverage Δ
AdvLoggerPkg 3.60% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raymond-MS Raymond-MS closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PcdAdvancedHdwLoggerDisable Is Still Referenced In README
2 participants