Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MfciPkg: Removed TargetVerifyPhaseSuite Tests suite since it did not contain any tests. #522

Merged
merged 3 commits into from
Jul 12, 2024
Merged

MfciPkg: Removed TargetVerifyPhaseSuite Tests suite since it did not contain any tests. #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1494b02
Removed TargetVerifyPhaseSuite Tests suite since it did not contain a…
apop5 Jul 12, 2024
17f5c89
Update pip-requirements for latest mu_basecore which include a rust c…
apop5 Jul 12, 2024
14ffac3
Corrected test suite for ReportRouterExtraDataSuite, which was regist…
apop5 Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions MfciPkg/MfciDxe/Test/MfciVerifyPolicyAndChangeHostTest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,6 @@ UefiTestMain (
{
EFI_STATUS Status;
UNIT_TEST_FRAMEWORK_HANDLE Framework;
UNIT_TEST_SUITE_HANDLE TargetVerifyPhaseSuite;
UNIT_TEST_SUITE_HANDLE VerifyAndChangePhaseSuite;

Framework = NULL;
Expand All @@ -817,16 +816,6 @@ UefiTestMain (

// The blob parsing part is tested in MfciPolicyParsingUnitTest, so will not go through those here.

//
// Populate the TargetVerifyPhaseSuite Unit Test Suite.
//
Status = CreateUnitTestSuite (&TargetVerifyPhaseSuite, Framework, "TargetVerifyPhase", "ReportRouter.Phase", NULL, NULL);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "Failed in CreateUnitTestSuite for TargetVerifyPhaseSuite\n"));
Status = EFI_OUT_OF_RESOURCES;
goto EXIT;
}

//
// Populate the VerifyAndChangePhaseSuite Unit Test Suite.
//
Expand Down
11 changes: 0 additions & 11 deletions MfciPkg/MfciDxe/Test/MfciVerifyPolicyAndChangeRoTHostTest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ UefiTestMain (
{
EFI_STATUS Status;
UNIT_TEST_FRAMEWORK_HANDLE Framework;
UNIT_TEST_SUITE_HANDLE TargetVerifyPhaseSuite;
UNIT_TEST_SUITE_HANDLE VerifyAndChangePhaseSuite;

Framework = NULL;
Expand All @@ -264,16 +263,6 @@ UefiTestMain (

// The blob parsing part is tested in MfciPolicyParsingUnitTest, so will not go through those here.

//
// Populate the TargetVerifyPhaseSuite Unit Test Suite.
//
Status = CreateUnitTestSuite (&TargetVerifyPhaseSuite, Framework, "TargetVerifyPhase", "ReportRouter.Phase", NULL, NULL);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "Failed in CreateUnitTestSuite for TargetVerifyPhaseSuite\n"));
Status = EFI_OUT_OF_RESOURCES;
goto EXIT;
}

//
// Populate the VerifyAndChangePhaseSuite Unit Test Suite.
//
Expand Down
4 changes: 2 additions & 2 deletions MsWheaPkg/MsWheaReport/Test/MsWheaReportCommonHostTest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,8 +757,8 @@ UefiTestMain (
goto EXIT;
}

AddTestCase (ReportRouterDataSuite, "ReportHwErrRecRouter should populate the extra WHEA data", "PopulateExtraData", ReportRouterPopulateWheaExtraData, NULL, NULL, NULL);
AddTestCase (ReportRouterDataSuite, "ReportHwErrRecRouter should not populate the extra WHEA data in invalid phases", "SkipEsPhases", ReportRouterSkipExtraDataInInvalidPhases, NULL, NULL, NULL);
AddTestCase (ReportRouterExtraDataSuite, "ReportHwErrRecRouter should populate the extra WHEA data", "PopulateExtraData", ReportRouterPopulateWheaExtraData, NULL, NULL, NULL);
AddTestCase (ReportRouterExtraDataSuite, "ReportHwErrRecRouter should not populate the extra WHEA data in invalid phases", "SkipEsPhases", ReportRouterSkipExtraDataInInvalidPhases, NULL, NULL, NULL);

//
// Execute the tests.
Expand Down
2 changes: 1 addition & 1 deletion pip-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
##

edk2-pytool-library==0.21.8
edk2-pytool-extensions==0.27.6
edk2-pytool-extensions==0.27.10
antlr4-python3-runtime==4.13.1
regex==2024.5.15
pygount==1.8.0
Loading