Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MfciPkg: Removed TargetVerifyPhaseSuite Tests suite since it did not contain any tests. #522

Merged

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Jul 12, 2024

Description

MfciVerifyPolicyAndChangeRoTHostTest.c and MfciVerifyPolicyAndChangeHostTest.c both contained an additonal registered test suite that did not contain any tests.

MsWheaPkg also contained a test suite where the tests associated were not registered correctly.

This started failing after fd8a09795aa where empty test suites will now be reported as an error.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Local CI passed after change.

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact impact:testing Affects testing labels Jul 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.04%. Comparing base (c024ed1) to head (14ffac3).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311     #522   +/-   ##
===============================================
  Coverage           11.04%   11.04%           
===============================================
  Files                 144      144           
  Lines               22019    22019           
  Branches             2356     2356           
===============================================
  Hits                 2432     2432           
  Misses              19555    19555           
  Partials               32       32           
Flag Coverage Δ
AdvLoggerPkg 3.65% <ø> (ø)
HidPkg 2.80% <ø> (ø)
MfciPkg 39.37% <ø> (ø)
MsCorePkg 1.43% <ø> (ø)
MsWheaPkg 7.13% <ø> (ø)
XmlSupportPkg 27.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ering test to ReportRouterDataSuite by accident
@apop5 apop5 enabled auto-merge (squash) July 12, 2024 23:22
@apop5 apop5 merged commit 8d38e9e into microsoft:release/202311 Jul 12, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants