-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: The Trashcan icon does not show on the right side of the ListBox #554
Labels
state:needs-triage
Needs to triaged to determine next steps
type:bug
Something isn't working
urgency:high
Significant with a critical impact
Comments
wenbhou
added
state:needs-triage
Needs to triaged to determine next steps
type:bug
Something isn't working
labels
Aug 21, 2024
5 tasks
wenbhou
changed the title
[Bug]: <title> The Trashcan icon does not show on the right side of the ListBox
[Bug]: The Trashcan icon does not show on the right side of the ListBox
Aug 21, 2024
makubacki
added a commit
that referenced
this issue
Aug 22, 2024
… list box (#552) ## Description Fixes #554 - Adjusted CellTrashcanBounds.Left to be CellBounds->Right - TrashcanHitAreaWidth to ensure the trash can icon is displayed to the right of the list box. - Updated width parameter in SWM_RECT_INIT2 to use TrashcanHitAreaWidth instead of CheckBoxHitAreaWidth for correct dimensions. This resolves the issue of the trash can icon overlapping with the ListBox's deletable item's checkbox thus ensuring its related operations work correctly: activating/deactivating the Load Option or deleting it. ## How This Was Tested Verified that a Load Option allowed to be deleted, such as 'Windows Boot Manager', can now be deleted by pressing the trash icon in its proper position or activated via its check-box. ## Integration Instructions N/A Co-authored-by: Michael Kubacki <[email protected]>
apop5
pushed a commit
to apop5/mu_plus
that referenced
this issue
Aug 27, 2024
… Load Option's list box (microsoft#552) Fixes microsoft#554 - Adjusted CellTrashcanBounds.Left to be CellBounds->Right - TrashcanHitAreaWidth to ensure the trash can icon is displayed to the right of the list box. - Updated width parameter in SWM_RECT_INIT2 to use TrashcanHitAreaWidth instead of CheckBoxHitAreaWidth for correct dimensions. This resolves the issue of the trash can icon overlapping with the ListBox's deletable item's checkbox thus ensuring its related operations work correctly: activating/deactivating the Load Option or deleting it. Verified that a Load Option allowed to be deleted, such as 'Windows Boot Manager', can now be deleted by pressing the trash icon in its proper position or activated via its check-box. N/A Co-authored-by: Michael Kubacki <[email protected]>
apop5
pushed a commit
that referenced
this issue
Aug 27, 2024
… Load Option's list box (#552) Fixes #554 - Adjusted CellTrashcanBounds.Left to be CellBounds->Right - TrashcanHitAreaWidth to ensure the trash can icon is displayed to the right of the list box. - Updated width parameter in SWM_RECT_INIT2 to use TrashcanHitAreaWidth instead of CheckBoxHitAreaWidth for correct dimensions. This resolves the issue of the trash can icon overlapping with the ListBox's deletable item's checkbox thus ensuring its related operations work correctly: activating/deactivating the Load Option or deleting it. Verified that a Load Option allowed to be deleted, such as 'Windows Boot Manager', can now be deleted by pressing the trash icon in its proper position or activated via its check-box. N/A Co-authored-by: Michael Kubacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
state:needs-triage
Needs to triaged to determine next steps
type:bug
Something isn't working
urgency:high
Significant with a critical impact
Is there an existing issue for this?
Current Behavior
The Trashcan icon is currently showing on the left side and overlapping the checkbox icon.
Expected Behavior
The Trashcan should be shown on the right side of the ListBox.
Steps To Reproduce
Build Environment
Version Information
Urgency
High
Are you going to fix this?
I will fix it
Do you need maintainer feedback?
No maintainer feedback needed
Anything else?
No response
The text was updated successfully, but these errors were encountered: