[SQUASH ON REBASE] Revert "MdePkg/CompilerIntrinsicsLib: Add IntrinsicLib class and strcmp" #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
added
the
type:design-change
github-actions
bot
added
impact:breaking-change
5 tasks
os-d
approved these changes
Aug 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #1086 +/- ##
==================================================
- Coverage 1.35% 1.31% -0.04%
==================================================
Files 1304 1303 -1
Lines 333854 333781 -73
Branches 5103 5103
==================================================
- Hits 4512 4385 -127
+ Misses 329259 329229 -30
- Partials 83 167 +84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Aug 1, 2024
…cLib class and strcmp" The strcmp function was added to CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c in edk2 commit 46226fb. Therefore, ARM and AARCH64 modules can pick up the strcmp function needed to compile code from there without adding more functionality to CompilerIntrinsicsLib just for building third-party crypto code. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
armcompint_remove_strcmp_2311
branch
from
97a964b to
c96338a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
strcmpfunction was added to CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c in edk2 commit 46226fb. Therefore, ARM and AARCH64 modules can pick up thestrcmpfunction needed to compile code from there without adding more functionality toCompilerIntrinsicsLibjust for building third-party crypto code.How This Was Tested
Integration Instructions
strcmpwill no longer be provided inArmCompilerIntrinsicsLib, useanother implementation if needed. Marked potentially breaking for this reason.