Use OpenSSL intrinsic lib for all archs #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
added
the
semver:patch
github-actions
bot
added
the
impact:non-functional
|
NOTE: I will update the |
os-d
approved these changes
Aug 1, 2024
apop5
approved these changes
Aug 1, 2024
makubacki
force-pushed
the
armcompint_remove_strcmp
branch
from
cec4f43 to
0bfff24
Compare
In rare cases the platform may not provide the full IntrinsicLib. But openssl30 build always require strcmp, provide this function by moving it into CrtWrapper.c. Signed-off-by: Yi Li <[email protected]> Cc: Jiewen Yao <[email protected]> Cc: Xiaoyu Lu <[email protected]> Cc: Guomin Jiang <[email protected]> Reviewed-by: Jiewen Yao <[email protected]> Acked-by: Ard Biesheuvel <[email protected]> Tested-by: Ard Biesheuvel <[email protected]> Tested-by: Brian J. Johnson <[email protected]> Tested-by: Kenneth Lautner <[email protected]> (cherry picked from commit 46226fb5d32f6e24eb8f8f48cceb0f67fd8585d4)
ArmCompilerIntrinsicsLib was previously used for ARM and AARCH64 code. With strcmp moving to CrtWrapper.c, the code can pick it up from there and use the OpensslPkg intrinisc lib instance. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
armcompint_remove_strcmp
branch
from
0bfff24 to
d75eee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ArmCompilerIntrinsicsLib was previously used for ARM and AARCH64
code. With
strcmpmoving to CrtWrapper.c, the code can pick it upfrom there and use the OpensslPkg intrinsic lib instance.
The
MU_BASECOREsubmodule is updated to bring in a cherry-pick ofthe edk2 change that moves the
strcmpfunction.How This Was Tested
Integration Instructions