2405: BaseTools/MuCodeQlQueries.qls: Removed unused static function query #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
added
the
semver:patch
github-actions
bot
added
the
impact:non-functional
os-d
approved these changes
Jul 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #1067 +/- ##
=================================================
Coverage ? 1.35%
=================================================
Files ? 1436
Lines ? 359331
Branches ? 5355
=================================================
Hits ? 4858
Misses ? 354005
Partials ? 468
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Jul 25, 2024
This is the Project Mu equivalent of the following edk2 commit: 1bb9f47 --- This query seems to produce a rate of false positives with some common patterns in edk2 like passing function pointers for callback. Due to the usage of `STATIC` instead of `static` particularly for functions, this query was rarely used in the past. It is removed here to prevent future false positives. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
2405_remove_unused_static_query_fn
branch
from
001e1f0 to
ff0a330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the Project Mu equivalent of the following edk2 commit:
1bb9f47This commit can be squashed with the commit that adds
MuCodeQlQueries.qlsin the future.This query seems to produce a rate of false positives with some common patterns in edk2 like passing function pointers for callback.
Due to the usage of
STATICinstead ofstaticparticularly for functions, this query was rarely used in the past. It is removed here to prevent future false positives.How This Was Tested
staticfunction present in the codeIntegration Instructions