Skip to content

Commit

Permalink
2405: BaseTools/MuCodeQlQueries.qls: Removed unused static function q…
Browse files Browse the repository at this point in the history
…uery (#1067)

## Description

This is the Project Mu equivalent of the following edk2 commit:

`1bb9f47`

This commit can be squashed with the commit that adds
`MuCodeQlQueries.qls` in the future.

---

This query seems to produce a rate of false positives with some common
patterns in edk2 like passing function pointers for callback.

Due to the usage of `STATIC` instead of `static` particularly for
functions, this query was rarely used in the past. It is removed here to
prevent future false positives.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

- CodeQL with a `static` function present in the code

## Integration Instructions

- N/A

Signed-off-by: Michael Kubacki <[email protected]>
  • Loading branch information
makubacki authored Jul 25, 2024
1 parent 507275b commit d753ffc
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions BaseTools/Plugin/CodeQL/MuCodeQlQueries.qls
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@
id: cpp/missing-header-guard
- include:
id: cpp/unused-local-variable
- include:
id: cpp/unused-static-function
- include:
id: cpp/unused-static-variable

Expand Down

0 comments on commit d753ffc

Please sign in to comment.