Skip to content

Commit

Permalink
BaseTools/codeql: Update to CodeQL 2.18.1 (#1069)
Browse files Browse the repository at this point in the history
## Description

Updates to the latest CodeQL version to resolve query dependencies.

Currently, errors like this will be seen:

```
Not using precompiled NoSpaceForZeroTerminator.qlx: This QLX (written by CodeQL 2.18.1) uses a primitive 'internSets', which this QL engine is too old to evaluate.
```

This is related to a CodeQL release made a few hours ago:

[Release v2.18.1 · github/codeql-cli-binaries ·
GitHub](https://github.com/github/codeql-cli-binaries/releases/tag/v2.18.1)

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

- CI with CodeQL plugin enabled

## Integration Instructions

- Verify queries being used are compatible with CodeQL 2.18.1

Signed-off-by: Michael Kubacki <[email protected]>
  • Loading branch information
makubacki authored Jul 25, 2024
1 parent d2b553f commit 507275b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions BaseTools/Plugin/CodeQL/codeqlcli_ext_dep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"scope": "codeql-ext-dep",
"type": "web",
"name": "codeql_cli",
"source": "https://github.com/github/codeql-cli-binaries/releases/download/v2.17.3/codeql.zip",
"version": "2.17.3",
"sha256": "e5ac1d87ab38e405c9af5db234a338b10dffabc98a648903f1664dd2a566dfd5",
"source": "https://github.com/github/codeql-cli-binaries/releases/download/v2.18.1/codeql.zip",
"version": "2.18.1",
"sha256": "815f71c1a46e76f9dafdec26c2a4bab7ea4019a3773e91e39253e2d21cf792a2",
"compression_type": "zip",
"internal_path": "/codeql/",
"flags": ["set_shell_var", ],
Expand Down
6 changes: 3 additions & 3 deletions BaseTools/Plugin/CodeQL/codeqlcli_linux_ext_dep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
"scope": "codeql-linux-ext-dep",
"type": "web",
"name": "codeql_linux_cli",
"source": "https://github.com/github/codeql-cli-binaries/releases/download/v2.17.3/codeql-linux64.zip",
"version": "2.17.3",
"sha256": "9fba000c4b821534d354bc16821aa066fdb1304446226ea449870e64a8ad3c7a",
"source": "https://github.com/github/codeql-cli-binaries/releases/download/v2.18.1/codeql-linux64.zip",
"version": "2.18.1",
"sha256": "1547f4a3b509474404daf2e4b821f71cd93462ec45322d9124c2b04e3d52c771",
"compression_type": "zip",
"internal_path": "/codeql/",
"flags": ["set_shell_var", ],
Expand Down
6 changes: 3 additions & 3 deletions BaseTools/Plugin/CodeQL/codeqlcli_windows_ext_dep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
"scope": "codeql-windows-ext-dep",
"type": "web",
"name": "codeql_windows_cli",
"source": "https://github.com/github/codeql-cli-binaries/releases/download/v2.17.3/codeql-win64.zip",
"version": "2.17.3",
"sha256": "4c6fbf2ea2eaf0f47bf0347eacf54c6b9d6bdf7acb6b63e17f9e6f2dd83b34e7",
"source": "https://github.com/github/codeql-cli-binaries/releases/download/v2.18.1/codeql-win64.zip",
"version": "2.18.1",
"sha256": "eb69c9ce40142904965ca3f2491c989f12747d74358385e2e94c427b4324201c",
"compression_type": "zip",
"internal_path": "/codeql/",
"flags": ["set_shell_var", ],
Expand Down

0 comments on commit 507275b

Please sign in to comment.