Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

fix(spans): adhere attribute name to otel semver #434

Merged
merged 3 commits into from
Oct 11, 2024
Merged

fix(spans): adhere attribute name to otel semver #434

merged 3 commits into from
Oct 11, 2024

Conversation

Strazz1337
Copy link
Contributor

Overview

Updates the http span attributes to match with the updated OTEL specification.

Related Issue

Fixes #409 (issue)

@Strazz1337 Strazz1337 requested a review from a team as a code owner October 11, 2024 17:35
@baywet baywet linked an issue Oct 11, 2024 that may be closed by this pull request
http - retry handler attributes updates #402
Closed
baywet
baywet suggested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

kiota_http/middleware/retry_handler.py Outdated Show resolved Hide resolved
baywet
baywet previously approved these changes Oct 11, 2024
View reviewed changes
@baywet baywet enabled auto-merge October 11, 2024 18:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@baywet baywet mentioned this pull request Oct 11, 2024
Merged
4 tasks
@baywet baywet merged commit ba1af4d into microsoft:main Oct 11, 2024
11 checks passed
@Strazz1337 Strazz1337 deleted the fix-adhere-to-otel-span branch October 11, 2024 19:15
@gopidesupavan gopidesupavan mentioned this pull request Oct 11, 2024
Closed
andrueastman added a commit to microsoft/kiota-python that referenced this pull request Oct 14, 2024
@andrueastman
sync sources for microsoft/kiota-http-python#434
505c5b9
@andrueastman andrueastman mentioned this pull request Oct 14, 2024
Merged
andrueastman added a commit to microsoft/kiota-python that referenced this pull request Oct 14, 2024
@andrueastman
Merge pull request #351 from microsoft/andrueastman/syncSources
8a41b73 
sync sources for microsoft/kiota-http-python#434
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http - align OTEL http attributes with latest standard http - retry handler attributes updates
2 participants
@Strazz1337 @baywet