-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge sources into one repo #329
Conversation
…dation adds validation with generated project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
started reviewing the PR but stopped midway through since I realized #331 still needs to be merged in this branch anyway
Thanks @baywet, Just to set expectations here, once we close #331, I'll need to make some updates to do the following before this is fully ready for review.
|
@andrueastman the policy definition probably needs to be updated here |
agreed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff @andrueastman!
this PR also needs to be ported microsoft/kiota-http-python#434 |
The merge-base changed after approval.
|
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
Conflicts have been resolved. A maintainer will take a look shortly. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Fixes #302
Fixes #174
Todo