File Actions menu #31220
File Actions menu #31220
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| </ui:MenuItem.Icon> | ||
| </ui:MenuItem> | ||
| <Separator/> | ||
| <ui:MenuItem Header="Copy path of files sperated by"> |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
|
@niels9001 Do you have an idea why the contextmenu doesn't take the WPFUI style? |
… to replace filename with hash
There was a problem hiding this comment.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This comment has been minimized.
This comment has been minimized.
…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Hi @Aaron-Junker , Thanks for the fixes.
I've merged the current main and fix an issue in runner.cpp after the merge.
I've given it some quick tests and found some quick issues, can you please take a look?
Feedback:
1 - The File Locksmith entry still appears even if the module is turned off. I imagine the same might be true with the other utilities we're trying to show.
2 - When trying to move or copy a collection of files and folder to another where there will be conflicts, nothing happens. We see a progress bar appearing for a fraction and just disappearing.
3 - When trying to collapse a folder structure where it would cause file conflicts, it did seems to have done what it could until it found the first conflict and then exited, without trying any other files after that. This means we ended up with an incomplete operation. Once again all feedback the user has was that a progress bar was seen for a bit and then disappeared. So the conflict dialog was removed from the utility? Anyway, much better than deleting ignored files.
4 - Save file as also doesn't do anything or give any UI feedback in case there's a conflict, just silently fails.
|
@jaimecbernardo It seems like the conflict dialog causes the process to crash, cause I didn't remove it. |
@Aaron-Junker , can you please fix it and mention me once I can re-review 😉 Thank you! |
|
@jaimecbernardo The conflict dialog works again now. And disabled modules are now respected. Thank you for the feedback. |
|
|
||
| public IconElement? Icon => IconHelper.GetIconFromModuleName("ImageResizer"); | ||
|
|
||
| public bool IsVisible => SelectedItems.All(path => path.IsImage()) && GPOWrapperProjection.GPOWrapper.GetConfiguredImageResizerEnabledValue() != GPOWrapperProjection.GpoRuleConfigured.Disabled && SettingsRepository<GeneralSettings>.GetInstance(new SettingsUtils()).SettingsConfig.Enabled.ImageResizer; |
There was a problem hiding this comment.
This policy check won't work as expected if the module is force enabled by policy. Correct? Then you need to improve the check.
There was a problem hiding this comment.
Why? As long as it is not disabled (either manually or by policy) it will show (regardless of how it is enabled. Or what am I missing here exactly?
There was a problem hiding this comment.
The policy can override manual disabling (force enabled). This should happen if policy value equals enabled.
|
Hi @Aaron-Junker , I've tried merging in latest main since the PR was missing the .NET 9 upgrade that got into main. File Actions menu seems to be crashing at startup for me, though, according to event logs. Are you able to run it? |
Summary of the Pull Request
Adding a new menu invokable by selecting files in explorer and pressing a shortcut set in the settings.
Screenshots
PR Checklist
Detailed Description of the Pull Request / Additional comments
Things left to do:
Validation Steps Performed