Skip to content

Commit

Permalink
Merge "orgin/main" into "dev/aaron-junker/FileActionsMenu"
Browse files Browse the repository at this point in the history
  • Loading branch information
Aaron-Junker committed Jan 17, 2024
2 parents 8fcfb3c + 42cfb46 commit bc1214a
Show file tree
Hide file tree
Showing 468 changed files with 6,791 additions and 3,187 deletions.
2 changes: 2 additions & 0 deletions .github/actions/spell-check/allow/names.txt
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ talynone
TBM
tilovell
Triet
waaverecords
ycv
Yuniardi
yuyoyuppe
Expand All @@ -140,6 +141,7 @@ onenote
Quickime
regedit
roslyn
Spotify
Vanara
WEX
windowwalker
Expand Down
38 changes: 17 additions & 21 deletions .github/actions/spell-check/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ accctrl
Acceleratorkeys
ACCEPTFILES
ACCESSDENIED
ACCESSTOKEN
aclapi
AClient
AColumn
Expand All @@ -34,6 +35,7 @@ ALPHATYPE
AModifier
AMPROPERTY
AMPROPSETID
animatedvisuals
ANDSCANS
ansicolor
ANull
Expand Down Expand Up @@ -160,7 +162,6 @@ CHANGECBCHAIN
changecursor
CHILDACTIVATE
CHILDWINDOW
CHT
cidl
cim
CImage
Expand All @@ -181,6 +182,7 @@ clrcall
CLSCTX
Clusion
cmder
CMDNOTFOUNDMODULEINTERFACE
Cmds
CMIC
CMINVOKECOMMANDINFO
Expand Down Expand Up @@ -218,7 +220,6 @@ CONFIGW
CONFLICTINGMODIFIERKEY
CONFLICTINGMODIFIERSHORTCUT
CONOUT
constexpr
consts
contentdialog
contentfiles
Expand Down Expand Up @@ -318,7 +319,6 @@ DESKTOPABSOLUTEEDITING
DESKTOPABSOLUTEPARSING
desktopshorcutinstalled
desktopwindowxamlsource
DEU
devblogs
devdocs
devenum
Expand Down Expand Up @@ -507,6 +507,7 @@ GETCLIENTAREAANIMATION
GETDESKWALLPAPER
GETDLGCODE
GETDPISCALEDSIZE
getfilesiginforedist
GETICON
GETMINMAXINFO
GETPROPERTYSTOREFLAGS
Expand Down Expand Up @@ -537,7 +538,6 @@ Hanzi
Hardlines
hardlinks
HARDWAREINPUT
hashcode
Hashset
hashtag
HASHVAL
Expand All @@ -556,7 +556,6 @@ hcwhite
hdc
hdrop
hdwwiz
HEB
Helpline
helptext
HGFE
Expand Down Expand Up @@ -719,7 +718,6 @@ jif
jjw
jobject
jpe
JPN
jpnime
Jsons
jsonval
Expand All @@ -745,12 +743,11 @@ killrunner
Knownfolders
KSPROPERTY
Kybd
LAlt
Lambson
languagesjson
langword
lastbuildstate
lastcodeanalysissucceeded
Lastdevice
LASTEXITCODE
LAYOUTRTL
LCIDTo
lcl
Expand Down Expand Up @@ -906,6 +903,8 @@ MOUSEHWHEEL
MOUSEINPUT
MOVESIZEEND
MOVESIZESTART
MOZILLAPL
MOZPL
mpmc
MRM
MRT
Expand All @@ -921,6 +920,7 @@ MSIFASTINSTALL
MSIHANDLE
msiquery
MSIRESTARTMANAGERCONTROL
msixbundle
MSIXCA
MSLLHOOKSTRUCT
Mso
Expand Down Expand Up @@ -971,6 +971,7 @@ newdev
newitem
newpath
newrow
newsgroups
NIF
NLD
NLog
Expand All @@ -983,7 +984,6 @@ NOCLOSEPROCESS
NOCOALESCE
NOCOPYBITS
nodeca
nodiscard
nodoc
NODRAWCAPTION
NODRAWICON
Expand Down Expand Up @@ -1092,7 +1092,6 @@ pcch
pcelt
pch
PCIDLIST
pcs
PCWSTR
pdisp
pdo
Expand Down Expand Up @@ -1276,6 +1275,7 @@ reparented
reparenting
reparse
reportbug
reportfileaccesses
requery
requerying
rescap
Expand Down Expand Up @@ -1303,7 +1303,6 @@ RKey
RNumber
roadmap
rop
roundf
ROUNDSMALL
rpcrt
RRF
Expand All @@ -1319,12 +1318,11 @@ rundll
rungameid
RUNLEVEL
runsettings
runspace
runtimeclass
runtimeobject
runtimepack
runtimes
RUS
RValue
rvm
rwin
rwl
Expand Down Expand Up @@ -1505,7 +1503,6 @@ subquery
Superbar
sut
svchost
SVE
SVGIn
SVGIO
svgz
Expand Down Expand Up @@ -1571,14 +1568,15 @@ timediff
timeunion
timeutil
Titlecase
tkcontrols
tkconverters
TKey
TLayout
tlb
tlbimp
TMPVAR
TNP
toggleswitch
tonos
toolkitcontrols
toolkitconverters
Toolset
Expand Down Expand Up @@ -1609,6 +1607,7 @@ UAL
uap
udit
uefi
uesc
UHash
UIA
UIEx
Expand All @@ -1617,6 +1616,7 @@ ums
uncompilable
UNCPRIORITY
UNDNAME
unescape
UNICODETEXT
uninstantiated
uniquifier
Expand All @@ -1635,6 +1635,7 @@ UOI
Updatelayout
UPGRADINGPRODUCTCODE
Uptool
urld
Usb
USEDEFAULT
USEFILEATTRIBUTES
Expand Down Expand Up @@ -1714,7 +1715,6 @@ wcsnicmp
WDA
wdp
wdupenv
weakme
webbrowsers
webcam
webpage
Expand All @@ -1723,7 +1723,6 @@ wekyb
Wevtapi
wgpocpl
WIC
wifi
wil
winapi
winappdriver
Expand Down Expand Up @@ -1851,9 +1850,6 @@ zonable
zoneset
Zoneszonabletester
zzz
newsgroups
MOZILLAPL
MOZPL

# FALSE POSITIVES

Expand Down
3 changes: 3 additions & 0 deletions .github/actions/spell-check/patterns.txt
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ aka\.ms/[a-zA-Z0-9]+
# YouTube url
\b(?:(?:www\.|)youtube\.com|youtu.be)/(?:channel/|embed/|user/|playlist\?list=|watch\?v=|v/|)[-a-zA-Z0-9?&=_%]*

# power shell gallery website
\bpowershellgallery.com/[-_a-zA-Z0-9()=./%]*

# uuid: (or CompGUIDPrefix)
L?(["']|[-<({>]|\b)[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{10,12}(?:\g{-1}|[<})>])

Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -348,3 +348,6 @@ src/common/Telemetry/*.etl

# Generated installer file for Monaco source files.
/installer/PowerToysSetup/MonacoSRC.wxs

# MSBuildCache
/MSBuildCacheLogs/
6 changes: 5 additions & 1 deletion .pipelines/ESRPSigning_core.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@

"PowerToys.AlwaysOnTop.exe",
"PowerToys.AlwaysOnTopModuleInterface.dll",


"PowerToys.CmdNotFoundModuleInterface.dll",
"PowerToys.CmdNotFound.dll",

"PowerToys.ColorPicker.dll",
"PowerToys.ColorPickerUI.dll",
"PowerToys.ColorPickerUI.exe",
Expand Down Expand Up @@ -251,6 +254,7 @@
"Mages.Core.dll",
"JetBrains.Annotations.dll",
"NLog.Extensions.Logging.dll",
"getfilesiginforedist.dll",
"concrt140_app.dll",
"msvcp140_1_app.dll",
"msvcp140_2_app.dll",
Expand Down
41 changes: 41 additions & 0 deletions .pipelines/ci/caching.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/microsoft/azure-pipelines-vscode/main/service-schema.json
trigger:
batch: true
branches:
include:
- main
- stable
paths:
exclude:
- doc/*
- temp/*
- tools/*
- '**.md'

pr:
branches:
include:
- main
- stable
paths:
exclude:
- '**.md'
- doc

# 0.0.yyMM.dd##
# 0.0.1904.0900
name: 0.0.$(Date:yyMM).$(Date:dd)$(Rev:rr)

variables:
EnablePipelineCache: true

jobs:
- template: ./templates/build-powertoys-precheck.yml
- template: ./templates/build-powertoys-ci.yml
parameters:
platform: x64
enableCaching: true
- template: ./templates/build-powertoys-ci.yml
parameters:
platform: arm64
enableCaching: true
16 changes: 13 additions & 3 deletions .pipelines/ci/templates/build-powertoys-ci.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
parameters:
configuration: 'Release'
platform: ''
additionalBuildArguments: '/p:RestorePackagesConfig=true -m'
- name: configuration
type: string
default: 'Release'
- name: platform
type: string
default: '/p:RestorePackagesConfig=true -m'
- name: additionalBuildArguments
type: string
default: '/p:RestorePackagesConfig=true -m'
- name: enableCaching
type: boolean
default: false

jobs:
- job: Build${{ parameters.platform }}${{ parameters.configuration }}
Expand All @@ -26,6 +35,7 @@ jobs:
- template: build-powertoys-steps.yml
parameters:
additionalBuildArguments: ${{ parameters.additionalBuildArguments }}
enableCaching: ${{ parameters.enableCaching }}

# It appears that the Component Governance build task that gets automatically injected stopped working
# when we renamed our main branch.
Expand Down
Loading

1 comment on commit bc1214a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log or 📝 job summary for details.

Unrecognized words (1)

sperated

Previously acknowledged words that are now absent applicationframehost Kazakhstani lastbuildstate qps Tenge TKey toolkitcontrols TValue unescape 🫥
Some files were automatically ignored 🙈

These sample patterns would exclude them:

(?:^|/)Microsoft\.WindowsAppSdk\.manifest$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words and update file exclusions, you could run the following commands

... in a clone of the [email protected]:microsoft/PowerToys.git repository
on the dev/aaron-junker/FileActionsMenu branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/7560455120/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (1854) from .github/actions/spell-check/expect.txt and unrecognized words (1)

Dictionary Entries Covers Uniquely
cspell:r/src/r.txt 543 1 1
cspell:cpp/src/people.txt 23 1
cspell:cpp/src/ecosystem.txt 51 1

Consider adding them (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries:
          cspell:r/src/r.txt
          cspell:cpp/src/people.txt
          cspell:cpp/src/ecosystem.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''
Errors (1)

See the 📜action log or 📝 job summary for details.

❌ Errors Count
❌ slow-file 7

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Please sign in to comment.