Remove Net 8 build from Language Server entirely

microsoft · Dec 6, 2023 · 5688652 · 5688652
1 parent dde3452
commit 5688652
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/DevSkim-DotNet/Microsoft.DevSkim.LanguageServer/Microsoft.DevSkim.LanguageServer.csproj b/DevSkim-DotNet/Microsoft.DevSkim.LanguageServer/Microsoft.DevSkim.LanguageServer.csproj
@@ -5,7 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <RootNamespace>DevSkim.LanguageServer</RootNamespace>
-    <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
+    <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <Authors>Microsoft</Authors>
     <copyright>© Microsoft Corporation. All rights reserved.</copyright> 

diff --git a/DevSkim-VSCode-Plugin/client/extension.ts b/DevSkim-VSCode-Plugin/client/extension.ts
@@ -26,7 +26,7 @@ async function resolveDotNetPath(): Promise<string> {
 	const result = await vscode.commands.executeCommand<any>(
 		"dotnet.acquire",
 		{
-			version: "8.0",
+			version: "7.0",
 			requestingExtensionId: "MS-CST-E.vscode-devskim",
 		}
 	);

diff --git a/DevSkim-VSCode-Plugin/package.json b/DevSkim-VSCode-Plugin/package.json
@@ -291,8 +291,8 @@
 		"clean:out": "npx --quiet -y rimraf --glob **/out && npx --quiet -y rimraf --glob **/tsconfig.tsbuildinfo",
 		"clean:modules": "npx --quiet -y rimraf --glob **/node_modules",
 		"clean:vsix": "npx --quiet -y rimraf --glob *.vsix",
-		"net-setup": "dotnet publish -c Debug -f net8.0 ../DevSkim-DotNet/Microsoft.DevSkim.LanguageServer -o devskimBinaries",
-		"net-setup:release": "dotnet publish -c Release -f net8.0 ../DevSkim-DotNet/Microsoft.DevSkim.LanguageServer -o devskimBinaries",
+		"net-setup": "dotnet publish -c Debug -f net7.0 ../DevSkim-DotNet/Microsoft.DevSkim.LanguageServer -o devskimBinaries",
+		"net-setup:release": "dotnet publish -c Release -f net7.0 ../DevSkim-DotNet/Microsoft.DevSkim.LanguageServer -o devskimBinaries",
 		"setup": "npm install && npm run net-setup",
 		"setup:release": "npm install && npm run net-setup:release",
 		"reset": "npm run clean && npm run setup",

diff --git a/Pipelines/vs/devskim-visualstudio-pr.yml b/Pipelines/vs/devskim-visualstudio-pr.yml
@@ -30,7 +30,7 @@ stages:
     parameters:
       buildTool: 'msbuild'
       buildConfiguration: 'Release'
-      dotnetVersion: '8.0.x'
+      dotnetVersion: '7.0.x'
       targetFramework: 'net47'
       projectPath: 'DevSkim-DotNet/Microsoft.DevSkim.VisualStudio/Microsoft.DevSkim.VisualStudio.csproj'
       projectName: 'DevSkim_VS'

diff --git a/Pipelines/vscode/devskim-vscode-release.yml b/Pipelines/vscode/devskim-vscode-release.yml
@@ -40,7 +40,7 @@ stages:
       displayName: Install Dotnet SDK
       inputs:
         packageType: 'sdk'
-        version: '8.0.x'
+        version: '7.0.x'
     - task: CodeQL3000Init@0
     - task: Npm@1
       displayName: Build VS Code Plugin