Skip to content

Commit

Permalink
Try with net 8 sdk but targeting net 7 through msbuild
Browse files Browse the repository at this point in the history
  • Loading branch information
gfs committed Dec 5, 2023
1 parent 48a36aa commit dde3452
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions Pipelines/vs/devskim-visualstudio-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ stages:
parameters:
buildTool: 'msbuild'
buildConfiguration: 'Release'
# 12/5/23 - This has to be built with msbuild but the template refuses to fetch the latest version of msbuild
# so we have to build with net 7 for now as the version fetched does not support net 8
dotnetVersion: '7.0.x'
dotnetVersion: '8.0.x'
targetFramework: 'net47'
projectPath: 'DevSkim-DotNet/Microsoft.DevSkim.VisualStudio/Microsoft.DevSkim.VisualStudio.csproj'
projectName: 'DevSkim_VS'
Expand Down
4 changes: 1 addition & 3 deletions Pipelines/vs/devskim-visualstudio-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ stages:
parameters:
buildTool: 'msbuild'
buildConfiguration: 'Release'
# 12/5/23 - This has to be built with msbuild but the template refuses to fetch the latest version of msbuild
# so we have to build with net 7 for now as the version fetched does not support net 8
dotnetVersion: '7.0.x'
dotnetVersion: '8.0.x'
targetFramework: 'net47'
projectPath: 'DevSkim-DotNet/Microsoft.DevSkim.VisualStudio/Microsoft.DevSkim.VisualStudio.csproj'
projectName: 'DevSkim_VS'
Expand Down

0 comments on commit dde3452

Please sign in to comment.