Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCm and ROCm Apex fixes for AMD workflows #4230

Closed
wants to merge 10 commits into from
Closed

ROCm and ROCm Apex fixes for AMD workflows #4230

Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
71f73d7
Update ROCm installed version to 5.5
loadams Aug 29, 2023
33a1b57
Test with MI200 workflow enabled
loadams Aug 29, 2023
b24aaac
Merge branch 'master' into loadams/rocm-fixes
loadams Aug 29, 2023
1ea0e85
Merge branch 'master' into loadams/rocm-fixes
loadams Aug 31, 2023
fb75f34
Remove PR toggle after adding workflow dispatch
loadams Aug 31, 2023
7cbd4fb
Test updating the apex version
loadams Sep 11, 2023
0f254e5
Merge branch 'loadams/amd-apex' into loadams/rocm-fixes
loadams Sep 14, 2023
5cec8fc
Merge branch 'master' into loadams/rocm-fixes
loadams Sep 14, 2023
bb5c1b7
Merge branch 'master' into loadams/rocm-fixes
loadams Oct 4, 2023
f7a9ad9
Merge branch 'master' into loadams/rocm-fixes
loadams Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/amd-mi200.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

- name: Install pytorch
run: |
pip install -U --cache-dir $TORCH_CACHE torch torchvision --extra-index-url https://download.pytorch.org/whl/rocm5.4.2
pip install -U --cache-dir $TORCH_CACHE torch torchvision --extra-index-url https://download.pytorch.org/whl/rocm5.5
loadams marked this conversation as resolved.
Show resolved Hide resolved
python -c "import torch; print('torch:', torch.__version__, torch)"
python -c "import torch; print('CUDA available:', torch.cuda.is_available())"

Expand All @@ -45,6 +45,7 @@ jobs:
run: |
git clone https://github.com/ROCmSoftwarePlatform/apex.git
cd apex
git checkout torch_2.1_higher
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch comes from the suggestion here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rraminen and @jithunnair-amd - thoughts on this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is currently where we have the pytorch2.1-compatible changes. However, we were planning to move these changes into master branch so that it works with tip-of-tree upstream PyTorch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @pruthvistony @ramcherukuri

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loadams We were planning on doing the branch refactor next week, but if we want to move forward here, let's merge this PR, and we can file another PR post-refactor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, no need for this, we can wait until the changes are merged back into the master branch, thanks for the update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jithunnair-amd - no rush, I was just trying to make things work for the MI200 tests to be all green, and this was one thing we would need, but we can wait until these changes are back in master - I'll close this PR for now and we can re-open if we need.

CURRENT_VER=$(git rev-parse HEAD)
INSTALLED_VER=$(cat /blob/amd-apex/.venv_installed_version)
if [[ "$CURRENT_VER" != "$INSTALLED_VER" ]]; then
Expand Down