Use fastcdr-2.2.x for ROS 2 Rolling #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rhys Mainwaring <[email protected]>
- Replace Cdr::DDS_CDR with DDS_CDR - Update renamed functions. Signed-off-by: Rhys Mainwaring <[email protected]>
Ryanf55
approved these changes
May 24, 2024
hippo5329
approved these changes
May 24, 2024
|
Please check CI |
CI on an Ubuntu 22 image is not going to work because the upstream package for fastcdr 2.2.x is not available. We'll need a At the moment micro-ROS will not work with ROS 2 Jazzy. It is also a problem on RPi as the default image for Ubuntu server is now 24.04. |
|
How about add the conditional compilation by checking the fastcdr version? Then we can have one source for fastcdr v1 and v2. Jazzy will need additional ci. |
|
Can we consider this superseded by #226 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223 for
rolling.Would be good to have a
jazzybranch now that it has been released.