-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pyaro-readers using documented API #1401
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1401 +/- ##
============================================
+ Coverage 78.56% 78.58% +0.01%
============================================
Files 137 137
Lines 20905 20883 -22
============================================
- Hits 16424 16410 -14
+ Misses 4481 4473 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5b8bff4
to
d3b4af8
Compare
4a717eb
to
0eab84a
Compare
84a005c
to
b6d6c1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Change Summary
The current iteration of the pyaro reader assumes one can index into the pyaro object to get a structured numpy element containing the metadata. This PR changes this to implement using the pyaro interface.
In addition this PR tries to read the data into the
UngriddedData
object more efficiently than line-by-line.Related issue number
Possible fix for #1302
Checklist