Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pyaro-readers using documented API #1401

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

magnusuMET
Copy link
Collaborator

@magnusuMET magnusuMET commented Nov 11, 2024

Change Summary

The current iteration of the pyaro reader assumes one can index into the pyaro object to get a structured numpy element containing the metadata. This PR changes this to implement using the pyaro interface.

In addition this PR tries to read the data into the UngriddedData object more efficiently than line-by-line.

Related issue number

Possible fix for #1302

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@magnusuMET magnusuMET added this to the m2024-12 milestone Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 98.73418% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (c8b2b28) to head (38a6cf2).
Report is 6 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/io/pyaro/read_pyaro.py 98.55% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1401      +/-   ##
============================================
+ Coverage     78.56%   78.58%   +0.01%     
============================================
  Files           137      137              
  Lines         20905    20883      -22     
============================================
- Hits          16424    16410      -14     
+ Misses         4481     4473       -8     
Flag Coverage Δ
unittests 78.58% <98.73%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magnusuMET magnusuMET force-pushed the pyaro_reading branch 2 times, most recently from 5b8bff4 to d3b4af8 Compare November 11, 2024 13:47
@jgriesfeller jgriesfeller mentioned this pull request Nov 11, 2024
9 tasks
@magnusuMET magnusuMET force-pushed the pyaro_reading branch 2 times, most recently from 4a717eb to 0eab84a Compare November 11, 2024 15:34
@magnusuMET magnusuMET marked this pull request as ready for review November 12, 2024 09:05
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@magnusuMET magnusuMET merged commit f8ddad8 into main-dev Nov 12, 2024
8 checks passed
@magnusuMET magnusuMET deleted the pyaro_reading branch November 12, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants