Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pya init command #1402

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Nov 11, 2024

Change Summary

The title says it all

Related issue number

fix #1401

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller linked an issue Nov 11, 2024 that may be closed by this pull request
@jgriesfeller jgriesfeller self-assigned this Nov 11, 2024
@jgriesfeller jgriesfeller added the user-friendliness Updates that improve ease of use label Nov 11, 2024
@jgriesfeller jgriesfeller added this to the m2024-12 milestone Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (c8b2b28) to head (3bc258a).
Report is 18 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/scripts/cli.py 75.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1402      +/-   ##
============================================
+ Coverage     78.56%   78.58%   +0.01%     
============================================
  Files           137      137              
  Lines         20905    20899       -6     
============================================
- Hits          16424    16423       -1     
+ Misses         4481     4476       -5     
Flag Coverage Δ
unittests 78.58% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller marked this pull request as ready for review November 11, 2024 15:23
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, otherwise LGTM

pyaerocom/scripts/cli.py Outdated Show resolved Hide resolved
pyaerocom/scripts/cli.py Outdated Show resolved Hide resolved
@jgriesfeller jgriesfeller merged commit 2e4061b into main-dev Nov 12, 2024
7 of 8 checks passed
@jgriesfeller jgriesfeller deleted the 1390-add-pya-init-command-to-cli-to-init-mypyaerocom-path branch November 12, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-friendliness Updates that improve ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add pya init command to cli to init ~/MyPyaerocom path
2 participants