Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/prokka docker image #165

Merged
merged 3 commits into from
Mar 31, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions docker/toolkit-prokka/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
FROM ubuntu:18.04

# metadata
LABEL website="https://github.com/tseemann/prokka"
LABEL license="https://github.com/tseemann/prokka#licence"

# install dependencies
RUN apt-get update && \
apt-get -y --no-install-recommends install libdatetime-perl libxml-simple-perl libdigest-md5-perl git default-jre bioperl hmmer wget \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, do you know which tool needs java (default-jre) ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems to be the only tool that needs java (tool for finding CRISPR elements)
https://github.com/ctSkennerton/minced

zlib1g-dev python liblzma-dev libbz2-dev xz-utils curl g++ make \
less bzip2 gzip libidn11-dev &&\
apt-get clean && apt-get autoclean && rm -rf /var/lib/apt/lists/*

#get Bioperl
#RUN cpan Bio::Perl

# install bedtools 2.29.0 since >=2.27.0 is required for barrnap and the apt-get package is 2.25.0
# dependencies required for bedtools: zlib1g-dev python liblzma-dev libbz2-dev xz-utils curl g++
RUN wget https://github.com/arq5x/bedtools2/releases/download/v2.29.0/bedtools-2.29.0.tar.gz && \
tar -zxf bedtools-2.29.0.tar.gz && \
rm bedtools-2.29.0.tar.gz && \
cd bedtools2 && \
make

# add bedtools to PATH for barrnap test
ENV PATH="$PATH:/bedtools2/bin"

# install barrnap
RUN wget https://github.com/tseemann/barrnap/archive/0.9.tar.gz &&\
tar -zxf 0.9.tar.gz &&\
rm 0.9.tar.gz &&\
cd barrnap-0.9 &&\
make test

#get prokka
RUN git clone https://github.com/tseemann/prokka && \
cd prokka && \
git fetch origin pull/219/head:partialgenes && \
git checkout partialgenes

# install tbl2asn manually since the one included with prokka is expired.
RUN wget ftp://ftp.ncbi.nih.gov/toolbox/ncbi_tools/converters/by_program/tbl2asn/linux64.tbl2asn.gz -O linux64.tbl2asn.gz && \
gunzip linux64.tbl2asn.gz && \
mv linux64.tbl2asn /usr/bin/tbl2asn && \
chmod 755 /usr/bin/tbl2asn

# put prokka in PATH &
# set PATH to prioritize /usr/bin/tbl2asn before /prokka/binaries/tbl2asn
ENV PATH="$PATH:/prokka/bin"

#setupdb
RUN prokka --setupdb

WORKDIR /data

1 change: 1 addition & 0 deletions docker/toolkit-prokka/VERSION
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should apply the following versioning scheme to our docker images:
TOOLVERSION_IMAGEVERSION

For example in your case it would be 1.12.0-0. This way its easier to understand which version of a tool is used. If we update our image because we might are able to create a smaller image then we would increment the last number (i.e 1.12.0-1). This would be still compatible with semantic versioning. I believe we should apply this scheme to all of our images, but this would be seperate issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the version number in the VERSION file as you suggested.