Feature/prokka docker image #165
Conversation
|
|
||
| # install dependencies | ||
| RUN apt-get update && \ | ||
| apt-get -y --no-install-recommends install libdatetime-perl libxml-simple-perl libdigest-md5-perl git default-jre bioperl hmmer wget \ |
There was a problem hiding this comment.
Just out of curiosity, do you know which tool needs java (default-jre) ?
There was a problem hiding this comment.
This one seems to be the only tool that needs java (tool for finding CRISPR elements)
https://github.com/ctSkennerton/minced
docker/toolkit-prokka/VERSION
Outdated
| @@ -0,0 +1 @@ | |||
| 0.1.0 | |||
There was a problem hiding this comment.
I believe we should apply the following versioning scheme to our docker images:
TOOLVERSION_IMAGEVERSION
For example in your case it would be 1.12.0-0. This way its easier to understand which version of a tool is used. If we update our image because we might are able to create a smaller image then we would increment the last number (i.e 1.12.0-1). This would be still compatible with semantic versioning. I believe we should apply this scheme to all of our images, but this would be seperate issue.
There was a problem hiding this comment.
I've changed the version number in the VERSION file as you suggested.
First version of a custom docker image for prokka with support for partial genes, based on this pull request:
tseemann/prokka#219
Possible optimizations: