Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WTF-1799]: move external dependencies to devDependencies #84

Closed
wants to merge 2 commits into from
Closed

[WTF-1799]: move external dependencies to devDependencies #84

wants to merge 2 commits into from

Conversation

jeffersonRibeiro
Copy link
Contributor

@jeffersonRibeiro jeffersonRibeiro commented Feb 21, 2024 •
edited
Loading

Checklist

  • Contains unit tests ❌
  • Contains breaking changes ❌
  • Compatible with: MX 7️⃣, 8️⃣, 9️⃣, 🔟

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

To fix Snyk report on packages that Rollup does not bundle.

@jeffersonRibeiro jeffersonRibeiro requested a review from a team as a code owner February 21, 2024 09:37
@jeffersonRibeiro jeffersonRibeiro force-pushed the wtf/fix-ip-package-ssrf-vulnerability branch 2 times, most recently from 0c23e18 to b18d39a Compare February 21, 2024 14:33
@jeffersonRibeiro jeffersonRibeiro changed the title [WTF-1799]: update ip package to 2.0.1 [WTF-1799]: move extermal dependencies to devDependencies Feb 21, 2024
@jeffersonRibeiro jeffersonRibeiro force-pushed the wtf/fix-ip-package-ssrf-vulnerability branch 2 times, most recently from aca0016 to 4643a74 Compare February 21, 2024 14:41
@jeffersonRibeiro jeffersonRibeiro changed the title [WTF-1799]: move extermal dependencies to devDependencies [WTF-1799]: move external dependencies to devDependencies Feb 22, 2024
@jeffersonRibeiro jeffersonRibeiro force-pushed the wtf/fix-ip-package-ssrf-vulnerability branch from 4643a74 to 14e9f34 Compare February 22, 2024 10:31
legio-vi-ferrata
legio-vi-ferrata reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@legio-vi-ferrata legio-vi-ferrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review is done.

packages/pluggable-widgets-tools/configs/rollup.config.native.js Show resolved Hide resolved
packages/pluggable-widgets-tools/configs/rollup.config.js Show resolved Hide resolved
packages/pluggable-widgets-tools/CHANGELOG.md Outdated Show resolved Hide resolved
packages/pluggable-widgets-tools/package.json Outdated Show resolved Hide resolved
@jeffersonRibeiro jeffersonRibeiro force-pushed the wtf/fix-ip-package-ssrf-vulnerability branch 3 times, most recently from ec05b02 to 153bd5f Compare February 22, 2024 13:06
@jeffersonRibeiro jeffersonRibeiro force-pushed the wtf/fix-ip-package-ssrf-vulnerability branch 3 times, most recently from 3e36950 to f29142c Compare February 22, 2024 13:34
legio-vi-ferrata
legio-vi-ferrata approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@legio-vi-ferrata legio-vi-ferrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. 👍

@jeffersonRibeiro jeffersonRibeiro force-pushed the wtf/fix-ip-package-ssrf-vulnerability branch from 1d90f76 to 9185c57 Compare February 22, 2024 13:41
@jeffersonRibeiro jeffersonRibeiro deleted the wtf/fix-ip-package-ssrf-vulnerability branch February 22, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legio-vi-ferrata legio-vi-ferrata legio-vi-ferrata approved these changes

Assignees
No one assigned
Labels
pluggable-widgets-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffersonRibeiro @legio-vi-ferrata @mendix-widgets-framework