move external dependencies to devDependencies

mendix · Feb 21, 2024 · aca0016 · aca0016
1 parent 49aad35
commit aca0016
Show file tree

Hide file tree

Showing 6 changed files with 2,317 additions and 3,660 deletions.
diff --git a/packages/generator-widget/CHANGELOG.md b/packages/generator-widget/CHANGELOG.md
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
+### Fixed
+
+-   We moved external dependencies to devDependencies as it is more logical since those packages are not bundled by Rollup. This change also fix a [Server-side Request Forgery](https://security.snyk.io/vuln/SNYK-JS-IP-6240864) vulnerability reported by Snyk.
+
 ## [10.7.1] - 2024-02-15
 
 ### Changed

diff --git a/packages/pluggable-widgets-tools/CHANGELOG.md b/packages/pluggable-widgets-tools/CHANGELOG.md
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
+### Fixed
+
+-   We moved external dependencies to devDependencies as it is more logical since those packages are not bundled by Rollup. This change also fix a [Server-side Request Forgery](https://security.snyk.io/vuln/SNYK-JS-IP-6240864) vulnerability reported by Snyk.
+
 ## [10.7.1] - 2024-02-15
 
 ### Fixed

diff --git a/packages/pluggable-widgets-tools/configs/rollup.config.js b/packages/pluggable-widgets-tools/configs/rollup.config.js
@@ -45,6 +45,22 @@ const assetsDirName = "assets";
 const absoluteOutAssetsDir = join(absoluteOutPackageDir, assetsDirName);
 const outAssetsDir = join(outWidgetDir, assetsDirName);
 
+const commonExternalLibs = [
+    // "mendix" and internals under "mendix/"
+    /^mendix($|\/)/,
+
+    // "react"
+    /^react$/,
+
+    // "react/jsx-runtime"
+    /^react\/jsx-runtime$/,
+
+    // "react-dom"
+    /^react-dom$/
+];
+
+const webExternal = [...commonExternalLibs, /^big.js$/];
+
 /**
  * This function is used by postcss-url.
  * Its main purpose to "adjust" asset path so that
@@ -115,7 +131,7 @@ export default async args => {
                 file: join(outDir, `${widgetName}.editorPreview.js`),
                 sourcemap: !production ? "inline" : false
             },
-            external: editorPreviewExternal,
+            external: commonExternalLibs,
             plugins: [
                 postcss({
                     extensions: [".css", ".sass", ".scss"],
@@ -131,7 +147,7 @@ export default async args => {
                     extensions,
                     transpile: production,
                     babelConfig: { presets: [["@babel/preset-env", { targets: { safari: "12" } }]] },
-                    external: editorPreviewExternal
+                    external: commonExternalLibs
                 })
             ],
             onwarn
@@ -147,7 +163,7 @@ export default async args => {
                 file: join(outDir, `${widgetName}.editorConfig.js`),
                 sourcemap: false
             },
-            external: editorConfigExternal,
+            external: commonExternalLibs,
             treeshake: { moduleSideEffects: false },
             plugins: [
                 url({ include: ["**/*.svg"], limit: 143360 }), // SVG file size limit of 140 kB
@@ -156,7 +172,7 @@ export default async args => {
                     extensions,
                     transpile: true,
                     babelConfig: { presets: [["@babel/preset-env", { targets: { ie: "11" } }]] },
-                    external: editorConfigExternal
+                    external: commonExternalLibs
                 })
             ],
             onwarn
@@ -318,26 +334,6 @@ const imagesAndFonts = [
     "**/*.eot"
 ];
 
-const commonExternalLibs = [
-    // "mendix" and internals under "mendix/"
-    /^mendix($|\/)/,
-
-    // "react"
-    /^react$/,
-
-    // "react/jsx-runtime"
-    /^react\/jsx-runtime$/,
-
-    // "react-dom"
-    /^react-dom$/
-];
-
-const webExternal = commonExternalLibs.concat(/^big.js$/);
-
-const editorPreviewExternal = commonExternalLibs;
-
-const editorConfigExternal = commonExternalLibs;
-
 export function postCssPlugin(outputFormat, production, postcssPlugins = []) {
     return postcss({
         extensions: [".css", ".sass", ".scss"],

diff --git a/packages/pluggable-widgets-tools/configs/rollup.config.native.js b/packages/pluggable-widgets-tools/configs/rollup.config.native.js
@@ -35,6 +35,36 @@ const outWidgetFile = join(widgetPackage.replace(/\./g, "/"), widgetName.toLower
 const mpkDir = join(sourcePath, "dist", widgetVersion);
 const mpkFile = join(mpkDir, process.env.MPKOUTPUT ? process.env.MPKOUTPUT : `${widgetPackage}.${widgetName}.mpk`);
 
+const extensions = [".js", ".jsx", ".tsx", ".ts"];
+
+const editorConfigExternal = [
+    // "mendix" and internals under "mendix/"
+    /^mendix($|\/)/,
+
+    // "react"
+    /^react$/,
+
+    // "react/jsx-runtime"
+    /^react\/jsx-runtime$/,
+
+    // "react-dom"
+    /^react-dom$/
+];
+
+const nativeExternal = [
+    /^mendix($|\/)/,
+    /^react-native($|\/)/,
+    /^big.js$/,
+    /^react($|\/)/,
+    /^react-native-gesture-handler($|\/)/,
+    /^react-native-reanimated($|\/)/,
+    /^react-native-fast-image($|\/)/,
+    /^react-native-svg($|\/)/,
+    /^react-native-vector-icons($|\/)/,
+    /^react-navigation($|\/)/,
+    /^react-native-safe-area-context($|\/)/
+];
+
 export default async args => {
     const production = Boolean(args.configProduction);
 
@@ -250,33 +280,3 @@ export default async args => {
         }
     }
 };
-
-const extensions = [".js", ".jsx", ".tsx", ".ts"];
-
-const editorConfigExternal = [
-    // "mendix" and internals under "mendix/"
-    /^mendix($|\/)/,
-
-    // "react"
-    /^react$/,
-
-    // "react/jsx-runtime"
-    /^react\/jsx-runtime$/,
-
-    // "react-dom"
-    /^react-dom$/
-];
-
-const nativeExternal = [
-    /^mendix($|\/)/,
-    /^react-native($|\/)/,
-    /^big.js$/,
-    /^react($|\/)/,
-    /^react-native-gesture-handler($|\/)/,
-    /^react-native-reanimated($|\/)/,
-    /^react-native-fast-image($|\/)/,
-    /^react-native-svg($|\/)/,
-    /^react-native-vector-icons($|\/)/,
-    /^react-navigation($|\/)/,
-    /^react-native-safe-area-context($|\/)/
-];