Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to the OCaml 5.1.1 branch #926

Merged
merged 18 commits into from
Nov 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/opam-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- ubuntu-latest
# - windows-latest # for some reason windows build is not picking dune 3.5
ocaml-compiler:
- 5.1.x
- ocaml-variants.5.1.1+trunk

runs-on: ${{ matrix.os }}

Expand Down
2 changes: 2 additions & 0 deletions Changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ Unreleased
[#929](https://github.com/melange-re/melange/pull/929)
- BREAKING(runtime): Remove `Js.null_undefined` in favor of `Js.nullable`
([#930](https://github.com/melange-re/melange/pull/930))
- BREAKING(core): require OCaml 5.1.1
([#926](https://github.com/melange-re/melange/pull/926))

2.1.0 2023-10-22
---------------
Expand Down
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ opam-create-switch: ## Create opam switch

.PHONY: opam-install-test
opam-install-test: ## Install test dependencies
opam pin add js_of_ocaml-compiler --dev-repo -y
opam pin add js_of_ocaml --dev-repo -y
opam pin add merlin-lib git+https://github.com/voodoos/merlin#5.1.1-upgrade
opam pin add merlin git+https://github.com/voodoos/merlin#5.1.1-upgrade
opam pin add melange.dev . --with-test -y
opam pin add melange-playground.dev . --with-test -y

Expand Down
6 changes: 3 additions & 3 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,16 @@
} // (flake-utils.lib.eachDefaultSystem (system:
let
pkgs = nixpkgs.legacyPackages."${system}".extend (self: super: {
ocamlPackages = super.ocaml-ng.ocamlPackages_5_1;
ocamlPackages = super.ocaml-ng.ocamlPackages_5_1.overrideScope' (oself: osuper: {
ocaml = osuper.ocaml.overrideAttrs (_: {
src = super.fetchFromGitHub {
owner = "ocaml";
repo = "ocaml";
rev = "35fdd0226e2e05a1a8244ecfec780b563b23b59c";
hash = "sha256-SkxZhodkU5RBSaJ+p1NI/EtVEvHT1cOW8vks4Nf11tA=";
};
});
});
});

packages =
Expand Down
12 changes: 11 additions & 1 deletion nix/ci/test.nix
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,23 @@ let
nix-filter-src = findFlakeSrc { name = "nix-filter"; };
melange-compiler-libs-src = findFlakeSrc {
name = "melange-compiler-libs";
allRefs = true;
};
nix-filter = import "${nix-filter-src}";

pkgs = import src {
extraOverlays = [
(self: super: {
ocamlPackages = super.ocaml-ng."ocamlPackages_${ocamlVersion}";
ocamlPackages = super.ocaml-ng."ocamlPackages_${ocamlVersion}".overrideScope' (oself: osuper: {
ocaml = osuper.ocaml.overrideAttrs (_: {
src = super.fetchFromGitHub {
owner = "ocaml";
repo = "ocaml";
rev = "35fdd0226e2e05a1a8244ecfec780b563b23b59c";
hash = "sha256-SkxZhodkU5RBSaJ+p1NI/EtVEvHT1cOW8vks4Nf11tA=";
};
});
});
})
];
};
Expand Down
Loading