Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to the OCaml 5.1.1 branch #926

Merged
merged 18 commits into from
Nov 28, 2023
Merged

feat: upgrade to the OCaml 5.1.1 branch #926

merged 18 commits into from
Nov 28, 2023

Conversation

anmonteiro
Copy link
Member

fixes #922

@anmonteiro anmonteiro mentioned this pull request Nov 25, 2023
Closed
@anmonteiro
Copy link
Member Author

opened ocaml/opam-repository#24845 to be able to disable and compression and fix the opam tests.

@anmonteiro
Copy link
Member Author

I tried a few things but it looks like we'll need some kind of support from the opam-repository upstream for our OPAM pipeline to pass...

@Octachron
Copy link

Octachron commented Nov 26, 2023 •
edited
Loading

The root error seems to be that the vendored compilerlibs library is missing the Compression module.

@anmonteiro
Copy link
Member Author

The root error seems to be that the vendored compilerlibs library is missing the Compression module.

Why is that an error? We don't vendor a lot of the unnecessary modules upstream, and we'd rather not duplicate Compression.

Rather, we'd like to rely on the ability to turn off compression in CI, which is why I opened ocaml/opam-repository#24845.

As you can see, the Nix tests are perfectly fine, because we don't include libzstd and the OCaml compiler configuration script detects that.

@anmonteiro
Copy link
Member Author

anmonteiro commented Nov 26, 2023 •
edited
Loading

Now the melange-playground tests are failing – looks like we might need jsoo support for this release too:

Fatal error: exception Failure("caml_zstd_initialize not implemented")

@Octachron
Copy link

Indeed, js_of_ocaml need to implement the new primitve see ocsigen/js_of_ocaml#1534 .

I missed the fact that you were using the compiler-libs to compiled your vendored file, so everything should work without issues. Which means that I don't understand why you need to disable compression for your tests?

@anmonteiro
Copy link
Member Author

anmonteiro commented Nov 27, 2023 •
edited
Loading

Which means that I don't understand why you need to disable compression for your tests?

We use Merlin in our tests, which doesn’t seem to be able to read the compressed artifacts for 5.1.1 (perhaps because it’s been removed from the stdlib — Merlin might need to be updated as well).

@kit-ty-kate
Copy link
Contributor

Merlin might need to be updated as well

Yes I mentionned that in my above review. This is being worked on here: ocaml/merlin#1714

@anmonteiro
Copy link
Member Author

Thank you both for the assistance.

@anmonteiro anmonteiro merged commit 949c0d7 into main Nov 28, 2023
4 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/5.1.1 branch November 28, 2023 02:28
@anmonteiro anmonteiro mentioned this pull request Nov 28, 2023
Merged
@kit-ty-kate kit-ty-kate mentioned this pull request Nov 29, 2023
Merged
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Dec 6, 2023
@anmonteiro
[new release] melange (2 packages) (2.2.0)
ab930eb 
CHANGES:

- BREAKING(core): require OCaml 5.1.1
  ([melange-re/melange#926](melange-re/melange#926))
@anmonteiro anmonteiro mentioned this pull request Dec 6, 2023
Merged
sravan-s added a commit to sravan-s/melange that referenced this pull request Feb 13, 2024
@sravan-s
doc/fix: Add ocaml 5.1.1 as melange v3 dependency
eb663d6 
melange-re#926
@sravan-s sravan-s mentioned this pull request Feb 13, 2024
Merged
anmonteiro added a commit that referenced this pull request Feb 16, 2024
@sravan-s @anmonteiro
doc/fix: Add ocaml 5.1.1 as melange v3 dependency (#1063)
2f540d1 
* doc/fix: Add ocaml 5.1.1 as melange v3 dependency

#926

* Update README.md

* Update README.md

---------

Co-authored-by: Antonio Nuno Monteiro <[email protected]>
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
@anmonteiro @nberth
[new release] melange (2 packages) (2.2.0)
dcd41b0 
CHANGES:

- BREAKING(core): require OCaml 5.1.1
  ([melange-re/melange#926](melange-re/melange#926))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OCaml 5.1.1 support
3 participants
@anmonteiro @Octachron @kit-ty-kate