Make text more readable by using scrolling strings for bounded strings #8232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scrolling if it ends up going out of bounds
…ady display the information in the neighboring screen and the tooltip feels clunky
…so that we only have to define the max text bounds in one place
… scrolling text for default configs when set to english
…to make use of scrolling text for default configs when set to english
… that the dictionary's dropdown doesn't have to have scrolling text in english (currently still does for BE Types)
…ext for default configs in english
…not quite translating to the correct spot (seems to make it slightly more readable)
…ionary dropdowns fit within the gui in english without resorting to having to scroll
… text y value being slightly off
…y styles the component might have
…string depending on LTR or RTL language instead of starting at a random position
…, and further improve when scrolling text gets reset in relation to switching to recipe viewers and resizing MC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Replaces our concept of text scaled based on bound (which can make text tiny and impossible to read), with using mojang's scrolling text system