-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#9547): require password reset on first time login and admin password update #9731
base: master
Are you sure you want to change the base?
Conversation
Hi @jkuester I resolved the feedback you gave me and this implementation is leaner than the previous one. It is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming together nicely! Couple additional comments/suggestions here.
I think my only remaining workflow-level question is if you think we need some kind of message in the admin app when changing a user's password that will alert the admin that the user will be prompted to change their password again? I am just concernd that we will still catch folks off guard with this functionality change... 🤔
Hi @jkuester Good point about adding a sort of warning. I came up with this
|
@Benmuiruri Yes, that was exactly what I was thinking. Would it be possible to just hide it for users that have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! I had one minor suggestion about the update user code, but otherwise this is good to go!
Description
Video showing password reset in action
Screen.Recording.2025-01-10.at.10.29.17.mov
Video showing permission enabling skipping password reset
Screen.Recording.2025-01-10.at.10.32.14.mov
Video showing api supports setting password_change_required: false for specific user
Screen.Recording.2025-01-10.at.10.44.23.mov
Video showing password change hint in admin app
Screen.Recording.2025-01-15.at.15.01.17.mov
Closes #9547
Code review checklist
can_view_old_navigation
permission to see the old design.Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.