-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos and pseudo-typos 1 #36242
Fix typos and pseudo-typos 1 #36242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Josh-Cena I've looked through these fixes and they look OK, but I do have one overriding concern — there may be external examples (e.g. in dom-examples or django-library-tutorial) that this could cause to go out of sync with their associated guides.
Do you intend to update those too, or would it be better to leave such examples (where you are marginally improving class or variable names, for example), alone, to avoid the hassle?
@chrisdavidmills It would be great if the example repos can be updated too. I don't know if I have time to do that, though. Usually in this sort of batch content update, example repos often lag behind, and that wouldn't be a reason to hold back content updates, because we have well-established linting infrastructure for content but not for example repos (we totally should). |
What is the value of fixing the pseudo typos? Ditto things like "game-over" vs "gameover" - I might use game_over, or gameOver for a state name, but I would never use All the actual typo fixes look great though. |
As a reader, a well-separated name is slightly easier to scan. If ease of selection is a showstopper for you, I'm happy to change it to an underscore. From a maintenance perspective, using valid words eliminates the chance of false-negative spell checking elsewhere since we don't have to exempt "firefoxlogo".
Here it's not a code entity though. I could be wrong but I searched everywhere and there's no reference to |
files/en-us/games/techniques/control_mechanisms/desktop_with_gamepad/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Josh-Cena - you've clearly been very careful. Appreciated.
I am fixing a lot of nits in content. The goal is to make our custom dictionaries as small as possible by eliminating things that could be better recognized as words. This not only helps with automation but helps with human readers too, especially those who may be slow to recognize words.
cSpell:ignore
to prevent it being ignored in other files.