Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #36447

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Fix typos #36447

merged 6 commits into from
Oct 26, 2024

Conversation

deerawj
Copy link
Contributor

@deerawj deerawj commented Oct 22, 2024

Description

Fixed some simple typos in comments and documentation.
Corrected an image filename and updated the reference to image.

While the typos were programmatically found, all of them were manually checked.
I also tried to read as much context as possible; so for example the instances where words are intentionally misspelled (labeledby, traget, mistypeVarible) are skipped.

Motivation

I originally used this repo to correct false positives in a spell checker I'm working on; but I noticed that there are some actual typos, so...

Additional details

None

Related issues and pull requests

None

@deerawj deerawj requested review from a team as code owners October 22, 2024 18:55
@deerawj deerawj requested review from sideshowbarker, bsmth and estelle and removed request for a team October 22, 2024 18:55
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:Other Any docs not covered by another "Content:" label Content:HTTP HTTP docs Content:Learn:Django Learning area Django docs Content:Glossary Glossary entries Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Learn:CSS Learning area CSS docs Content:Manifest Content:PWA Progressive Web Apps content size/m [PR only] 51-500 LoC changed labels Oct 22, 2024
Josh-Cena
Josh-Cena approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. FYI, we just recently adopted cSpell and it's giving us weekly spelling reports, e.g. #36323

We have a lot of existing typos, and they will be addressed in #36242 and its many siblings that remain open.

...rn/tools_and_testing/understanding_client-side_tools/introducing_complete_toolchain/index.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Preview URLs (25 pages)
Flaws (1)

Note! 24 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Privacy/Third-party_cookies
Title: Third-party cookies
Flaw count: 1

  • images:
    • External image URL
External URLs (1)

URL: /en-US/docs/Web/API/RTCRtpTransceiver/setCodecPreferences
Title: RTCRtpTransceiver: setCodecPreferences() method

(comment last updated: 2024-10-26 17:01:39)

bsmth
bsmth approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. There's one comment from Josh outstanding, but I think we can merge after you've had a look.

estelle
estelle approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment. Otherwise looks good.
Thank you. Also, congratulations on your first MDN content PR.
Welcome to the team!

files/en-us/web/api/customstateset/index.md Outdated Show resolved Hide resolved
@sideshowbarker sideshowbarker removed their request for review October 24, 2024 01:23
@github-actions github-actions bot removed the Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees label Oct 26, 2024
@github-actions github-actions bot removed the Content:Learn:CSS Learning area CSS docs label Oct 26, 2024
@Josh-Cena Josh-Cena merged commit c749deb into mdn:main Oct 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@estelle estelle estelle approved these changes

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Learn:Django Learning area Django docs Content:Manifest Content:Other Any docs not covered by another "Content:" label Content:PWA Progressive Web Apps content Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deerawj @estelle @bsmth @Josh-Cena