Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime.getURL fixes post merge feedback #35349

Merged
merged 1 commit into from
Aug 7, 2024
Merged

runtime.getURL fixes post merge feedback #35349

merged 1 commit into from
Aug 7, 2024

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Aug 7, 2024

Description

Addresses post merge feedback on #35136

@rebloor rebloor added the Content:WebExt WebExtensions docs label Aug 7, 2024
@rebloor rebloor requested a review from Rob--W August 7, 2024 03:10
@rebloor rebloor self-assigned this Aug 7, 2024
@rebloor rebloor requested review from a team as code owners August 7, 2024 03:10
@rebloor rebloor requested review from pepelsbey and removed request for a team August 7, 2024 03:10
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed labels Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/130
Title: Firefox 130 for developers

@rebloor rebloor mentioned this pull request Aug 7, 2024
Merged
Rob--W
Rob--W approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow up!

@Rob--W Rob--W merged commit c7270af into mdn:main Aug 7, 2024
7 checks passed
@rebloor rebloor deleted the runtime.getURL-fixes2 branch August 8, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

@pepelsbey pepelsbey Awaiting requested review from pepelsbey pepelsbey is a code owner automatically assigned from mdn/core-yari-content

Assignees

@rebloor rebloor

Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:WebExt WebExtensions docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebloor @Rob--W