runtime.getURL fixes #35136
runtime.getURL fixes #35136
Conversation
github-actions
bot
added
Content:Firefox
|
Preview URLs
External URLs (1)URL:
(comment last updated: 2024-08-01 02:43:40) |
| @@ -58,6 +58,8 @@ This article provides information about the changes in Firefox 130 that affect d | |||
|
|
|||
| ## Changes for add-on developers | |||
|
|
|||
| - {{WebExtAPIRef("runtime.getURL")}} (and the deprecated {{WebExtAPIRef("extension.getURL")}}) have been updated to prefix the supplied path string with the extension's `moz-extension:` origin (in line with the behavior of Chrome). In addition, {{WebExtAPIRef("runtime.getURL")}} no longer strips `/.`, `./`, and `../.` strings from the input URL ([Firefox bug 1795082](https://bugzil.la/1795082)). | |||
There was a problem hiding this comment.
The description here does not highlight the difference in comparison with the previous implementation.
A better description is to write that the extension origin is now always prepended to the path, without further normalization. Previously, when an absolute URL was provided instead of a relatively URL, that absolute URL was returned. "Without further normalization" captures changes like "/../" and "/./"
| @@ -26,7 +26,7 @@ browser.runtime.getURL( | |||
|
|
|||
| ### Return value | |||
|
|
|||
| `string`. The fully-qualified URL to the resource. | |||
| `string`. The fully-qualified URL to the resource. For example, `moz-extension://e15cdd35-f9b7-4786-a39d-7d801bd2709e/help/open-in-container.html`. | |||
There was a problem hiding this comment.
Let's drop this example. It is not obvious from just this description how the URL is derived from the input.
Furthermore, the code example below already offers a comment showing the format of the return value in Firefox specifically.
| `string`. The fully-qualified URL to the resource. For example, `moz-extension://e15cdd35-f9b7-4786-a39d-7d801bd2709e/help/open-in-container.html`. | |
| `string`. The fully-qualified URL to the resource within the extension. |
Description
Adds a release note for the changes made in Bug 1795082 browser.runtime.getURL() may return a non-extension URL and a clarifying example in runtime.getURL())