-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 32619: clarify font-weight descriptor #32853
base: main
Are you sure you want to change the base?
Conversation
Preview URLs External URLs (2)URL:
(comment last updated: 2024-10-29 20:43:17) |
@bsmth , I know you care about the repo size, and this PR adds some sample fonts to the repo, and one of them at least is quite big (127K). There was some chat before about having a separate repo for assets that live samples could refer to. That still feels like the proper solution. Do you know what the status of this is? I see https://github.com/mdn/shared-assets exists, can it be referenced from live samples in mdn/content? |
Yes, that was the idea, indeed.
This can't be used yet, my hope was that it would be added to a GCP bucket that we could reference like |
Hey @wbamberg - quick update to get something going in the meantime: I've enabled gh-pages for the assets repo in mdn/shared-assets#8 This allows you to use the fonts from that repo and add your own if you need different ones. The examples cleanup work we'll be doing later in the year will likely consider this assets repo and have more robust deployment, but that should unblock you for now (although we may need a CSP entry for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder you can use any of these instead of landing the assets in the content repo:
https://github.com/mdn/shared-assets/tree/main/fonts
i.e., https://mdn.github.io/shared-assets/fonts/FiraSans-Light.woff2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now we're using Fira Sans and League Mono!
I am linking #10910 to this PR. Would be helpful if you could see if there's anything else to be done about the issue, but I think it already suffices as a fix. |
Sorry @Josh-Cena . I will attempt to remember what's going on here. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am breaking things
Fixes #32619.
Fixes #10910
This is an attempt to improve the page on the
font-weight
descriptor. I think #32619 was fundamentally caused by the fact that this page isn't very clear about what thefont-weight
descriptor is, how it relates to thefont-weight
property, and how it is used. It includes stuff which is just wrong:...and stuff which makes it sound like this is the page for the property:
I've rewritten the description and syntax sections, more or less, and added two live samples that I hope show how this can actually be used.
I'm no expert here so might have mangled things. I do think though that this documentation could be improved. I think we should probably have glossary entries for font, font face, typeface, font family. We should probably have a proper guide to using
@font-face
- this is the only thing I could find and it's very basic. And if these changes or something like them are good, we should probably do something similar with the other descriptors.Oh, the live samples don't work, maybe because preview is broken? Sorry, you might need to test this locally.