Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Display error state when trip doesn't exist #527

Merged
merged 7 commits into from
Nov 12, 2024
Merged

fix: Display error state when trip doesn't exist #527

merged 7 commits into from
Nov 12, 2024

Commits on Nov 7, 2024

  1. fix: Display error state when trip doesn't exist 

    We can get added trip IDs that don't exist in the API in trip details,
which before these changes was resulting in shimmer loading forever.
Worse, it would continue to shimmer load even after switching to a
different vehicle on the map.
    @EmmaSimon
    EmmaSimon committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8909b33 View commit details
    Browse the repository at this point in the history

  2. fix: Fix tests and PR feedback

    @EmmaSimon
    EmmaSimon committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2f65877 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into es-trip-not-in-service

    @EmmaSimon
    EmmaSimon authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    56e6fd1 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge branch 'main' into es-trip-not-in-service

    @EmmaSimon
    EmmaSimon authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    7c22446 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into es-trip-not-in-service

    @EmmaSimon
    EmmaSimon authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    9b534a3 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Merge branch 'main' into es-trip-not-in-service

    @EmmaSimon
    EmmaSimon authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7dc569f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into es-trip-not-in-service

    @EmmaSimon
    EmmaSimon authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    e214d97 View commit details
    Browse the repository at this point in the history