fix: Display error state when trip doesn't exist #527
Merged
Xcode Cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
succeeded
Nov 12, 2024 in 23m 52s
43 warnings
| Report Summary | |
|---|---|
| Errors | 0 |
| Test Failures | 0 |
| Analysis Issues | 0 |
| Warnings | 43 |
Details
43 Warnings
Details
iosApp/iosApp/Pages/Map/HomeMapViewHandlerExtension.swift:281
Todo Violation: TODOs should be resolved (figure out something to do if ...) (todo)
Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Expression implicitly coerced from 'URLResponse?' to 'Any'
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Immutable value 'newConfig' was never used; consider replacing with '_' or removing it
Initialization of immutable value 'springboard' was never used; consider replacing with assignment to '_' or removing it
File Length Violation: File should contain 400 lines or less: currently contains 562 (file_length)
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 286 lines (type_body_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
Initialization of immutable value 'errorKey' was never used; consider replacing with assignment to '_' or removing it
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Todo Violation: TODOs should be resolved (Add all possible alert effects...) (todo)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Immutable value 'error' was never used; consider replacing with '_' or removing it
Line Length Violation: Line should be 120 characters or less; currently it has 150 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Todo Violation: TODOs should be resolved (Properly localize all possible...) (todo)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Prefer For-Where Violation: `where` clauses are preferred over a single `if` inside a `for` (for_where)
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 313 lines (type_body_length)
Initialization of immutable value 'mapVM' was never used; consider replacing with assignment to '_' or removing it
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 299 lines (type_body_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Immutable value 'error' was never used; consider replacing with '_' or removing it
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Unused Optional Binding Violation: Prefer `!= nil` over `let _ =` (unused_optional_binding)
Annotations
Check notice on line 14 in iosApp/iosApp/Pages/TripDetails/TripDetailsPage.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/Pages/TripDetails/TripDetailsPage.swift#L14
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 299 lines (type_body_length)
Loading