Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow knocking rooms #3647

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Allow knocking rooms #3647

merged 1 commit into from
Aug 3, 2023

Conversation

charlynguyen
Copy link
Contributor

@charlynguyen charlynguyen commented Aug 2, 2023 •
edited by github-actions bot
Loading

We @nordeck are currently implementing the knock rooms behind the feature flag feature_ask_to_join (introduced in matrix-org/matrix-react-sdk#11182).

This pull request allows knocking rooms.

Epic: element-hq/element-web#18655

Blocks

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@charlynguyen charlynguyen requested a review from a team as a code owner August 2, 2023 07:37
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Aug 2, 2023
t3chguy
t3chguy reviewed Aug 2, 2023
View reviewed changes
src/@types/requests.ts Outdated Show resolved Hide resolved
@charlynguyen charlynguyen mentioned this pull request Aug 2, 2023
Merged
3 tasks
Allow knocking rooms
d769e5c 
Signed-off-by: Charly Nguyen <[email protected]>
@charlynguyen charlynguyen force-pushed the charlynguyen/allow-knocking-rooms branch from beaeff9 to d769e5c Compare August 3, 2023 06:58
t3chguy
t3chguy approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, thanks

@t3chguy t3chguy enabled auto-merge August 3, 2023 08:11
@t3chguy t3chguy added this pull request to the merge queue Aug 3, 2023
Merged via the queue into matrix-org:develop with commit 2ef7ae7 Aug 3, 2023
17 checks passed
@charlynguyen charlynguyen deleted the charlynguyen/allow-knocking-rooms branch August 3, 2023 08:30
@charlynguyen charlynguyen mentioned this pull request Aug 4, 2023
Merged
3 tasks
@charlynguyen charlynguyen mentioned this pull request Aug 13, 2023
Merged
3 tasks
This was referenced Aug 23, 2023
Closed
Merged
This was referenced Aug 29, 2023
Closed
Merged
This was referenced Aug 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

@weeman1337 weeman1337 Awaiting requested review from weeman1337 weeman1337 is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlynguyen @t3chguy